eBPF loaded indicator #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
WithLoadedIndicatorInstrumentationOptionwhich enables the caller to be notified once all the probes are loaded. This is useful because theInstrumentation.Runfunction is blocking.The
Runfunction is consisted of 2 phases: The first one is responsible for loading all the relevant probes and the second is the main loop receiving and exporting the data. Hence, from the caller point of view there is no indication if the loading phase was successful and the probes are "ready".Splitting the
Runfunctions to 2 separate functions is problematic because it can cause the perf buffers to get full and data being lost if there is a large time gap between the loading phase and the main loop.