Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entry for opentelemetry-collector-contrib #18

Conversation

codeboten
Copy link
Contributor

This is to allow scope name to eventually use the vanity URL to identify the source of telemetry for components in that repository. Related issue: open-telemetry/opentelemetry-collector-contrib#21469

This is to allow scope name to eventually use the vanity URL to identify the source of telemetry for components in that repository. Related issue: open-telemetry/opentelemetry-collector-contrib#21469

Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten codeboten requested review from a team as code owners May 3, 2023 20:04
@codeboten
Copy link
Contributor Author

pinging @open-telemetry/collector-contrib-maintainer

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aneurysm9
Copy link
Member

This is to allow scope name to eventually use the vanity URL to identify the source of telemetry for components in that repository.

Is the plan to only use this for instrumentation scope name and to retain the github.com URLs for canonical import paths? If so, I'm supportive of this. Otherwise, I think we need to better understand the transition plan before making any changes.

@mx-psi
Copy link
Member

mx-psi commented May 4, 2023

Is the plan to only use this for instrumentation scope name and to retain the github.com URLs for canonical import paths? If so, I'm supportive of this. Otherwise, I think we need to better understand the transition plan before making any changes.

Agreed, specially if migrating import paths affects ocb manifests I think we should stop and think about the transition plan and whether it's worth it.

@codeboten
Copy link
Contributor Author

codeboten commented May 4, 2023

My understanding from the SIG call last Wednesday was that there was a wish to do both. Is the previous transition plan to go.opentelemetry.io/collector available somewhere?

This was the most obvious issue related to that transition i could find: open-telemetry/opentelemetry-collector#1034

@codeboten codeboten merged commit f252f17 into open-telemetry:main May 24, 2023
@codeboten codeboten deleted the codeboten/add-vanity-url-collector-contrib branch May 24, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants