-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add entry for opentelemetry-collector-contrib #18
Add entry for opentelemetry-collector-contrib #18
Conversation
This is to allow scope name to eventually use the vanity URL to identify the source of telemetry for components in that repository. Related issue: open-telemetry/opentelemetry-collector-contrib#21469 Signed-off-by: Alex Boten <aboten@lightstep.com>
pinging @open-telemetry/collector-contrib-maintainer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Is the plan to only use this for instrumentation scope name and to retain the github.com URLs for canonical import paths? If so, I'm supportive of this. Otherwise, I think we need to better understand the transition plan before making any changes. |
Agreed, specially if migrating import paths affects ocb manifests I think we should stop and think about the transition plan and whether it's worth it. |
My understanding from the SIG call last Wednesday was that there was a wish to do both. Is the previous transition plan to go.opentelemetry.io/collector available somewhere? This was the most obvious issue related to that transition i could find: open-telemetry/opentelemetry-collector#1034 |
This is to allow scope name to eventually use the vanity URL to identify the source of telemetry for components in that repository. Related issue: open-telemetry/opentelemetry-collector-contrib#21469