-
Notifications
You must be signed in to change notification settings - Fork 1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Replace internal aggregate Aggregator with Measure/ComputeAggregation…
… and a Builder (#4304)
- Loading branch information
Showing
18 changed files
with
577 additions
and
363 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,127 @@ | ||
| // Copyright The OpenTelemetry Authors | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package aggregate // import "go.opentelemetry.io/otel/sdk/metric/internal/aggregate" | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
| "go.opentelemetry.io/otel/attribute" | ||
| "go.opentelemetry.io/otel/sdk/metric/aggregation" | ||
| "go.opentelemetry.io/otel/sdk/metric/metricdata" | ||
| ) | ||
|
|
||
| // Measure receives measurements to be aggregated. | ||
| type Measure[N int64 | float64] func(context.Context, N, attribute.Set) | ||
|
|
||
| // ComputeAggregation stores the aggregate of measurements into dest and | ||
| // returns the number of aggregate data-points output. | ||
| type ComputeAggregation func(dest *metricdata.Aggregation) int | ||
|
|
||
| // Builder builds an aggregate function. | ||
| type Builder[N int64 | float64] struct { | ||
| // Temporality is the temporality used for the returned aggregate function. | ||
| // | ||
| // If this is not provided a default of cumulative will be used (except for | ||
| // the last-value aggregate function where delta is the only appropriate | ||
| // temporality). | ||
| Temporality metricdata.Temporality | ||
| // Filter is the attribute filter the aggregate function will use on the | ||
| // input of measurements. | ||
| Filter attribute.Filter | ||
| } | ||
|
|
||
| func (b Builder[N]) input(agg aggregator[N]) Measure[N] { | ||
| if b.Filter != nil { | ||
| agg = newFilter[N](agg, b.Filter) | ||
| } | ||
| return func(_ context.Context, n N, a attribute.Set) { | ||
| agg.Aggregate(n, a) | ||
| } | ||
| } | ||
|
|
||
| // LastValue returns a last-value aggregate function input and output. | ||
| // | ||
| // The Builder.Temporality is ignored and delta is use always. | ||
| func (b Builder[N]) LastValue() (Measure[N], ComputeAggregation) { | ||
| // Delta temporality is the only temporality that makes semantic sense for | ||
| // a last-value aggregate. | ||
| lv := newLastValue[N]() | ||
|
|
||
| return b.input(lv), func(dest *metricdata.Aggregation) int { | ||
| // TODO (#4220): optimize memory reuse here. | ||
| *dest = lv.Aggregation() | ||
|
|
||
| gData, _ := (*dest).(metricdata.Gauge[N]) | ||
| return len(gData.DataPoints) | ||
| } | ||
| } | ||
|
|
||
| // PrecomputedSum returns a sum aggregate function input and output. The | ||
| // arguments passed to the input are expected to be the precomputed sum values. | ||
| func (b Builder[N]) PrecomputedSum(monotonic bool) (Measure[N], ComputeAggregation) { | ||
| var s aggregator[N] | ||
| switch b.Temporality { | ||
| case metricdata.DeltaTemporality: | ||
| s = newPrecomputedDeltaSum[N](monotonic) | ||
| default: | ||
| s = newPrecomputedCumulativeSum[N](monotonic) | ||
| } | ||
|
|
||
| return b.input(s), func(dest *metricdata.Aggregation) int { | ||
| // TODO (#4220): optimize memory reuse here. | ||
| *dest = s.Aggregation() | ||
|
|
||
| sData, _ := (*dest).(metricdata.Sum[N]) | ||
| return len(sData.DataPoints) | ||
| } | ||
| } | ||
|
|
||
| // Sum returns a sum aggregate function input and output. | ||
| func (b Builder[N]) Sum(monotonic bool) (Measure[N], ComputeAggregation) { | ||
| var s aggregator[N] | ||
| switch b.Temporality { | ||
| case metricdata.DeltaTemporality: | ||
| s = newDeltaSum[N](monotonic) | ||
| default: | ||
| s = newCumulativeSum[N](monotonic) | ||
| } | ||
|
|
||
| return b.input(s), func(dest *metricdata.Aggregation) int { | ||
| // TODO (#4220): optimize memory reuse here. | ||
| *dest = s.Aggregation() | ||
|
|
||
| sData, _ := (*dest).(metricdata.Sum[N]) | ||
| return len(sData.DataPoints) | ||
| } | ||
| } | ||
|
|
||
| // ExplicitBucketHistogram returns a histogram aggregate function input and | ||
| // output. | ||
| func (b Builder[N]) ExplicitBucketHistogram(cfg aggregation.ExplicitBucketHistogram) (Measure[N], ComputeAggregation) { | ||
| var h aggregator[N] | ||
| switch b.Temporality { | ||
| case metricdata.DeltaTemporality: | ||
| h = newDeltaHistogram[N](cfg) | ||
| default: | ||
| h = newCumulativeHistogram[N](cfg) | ||
| } | ||
| return b.input(h), func(dest *metricdata.Aggregation) int { | ||
| // TODO (#4220): optimize memory reuse here. | ||
| *dest = h.Aggregation() | ||
|
|
||
| hData, _ := (*dest).(metricdata.Histogram[N]) | ||
| return len(hData.DataPoints) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.