-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fromEnv detector throws an error when OTEL_RESOURCE_ATTRIBUTES is not set. #2138
Labels
bug
Something isn't working
Comments
seanschade
added a commit
to seanschade/opentelemetry-go
that referenced
this issue
Jul 28, 2021
…rce when attributes are not supplied Fixes: open-telemetry#2138
Pull request to fix the bug. |
seanschade
added a commit
to seanschade/opentelemetry-go
that referenced
this issue
Jul 28, 2021
…rce when attributes are not supplied Fixes: open-telemetry#2138
MrAlias
added a commit
that referenced
this issue
Jul 29, 2021
…rce (#2139) * fix(2138): add guard to constructOTResources to return an empty resource when attributes are not supplied Fixes: #2138 * Update CHANGELOG.md Co-authored-by: Robert Pająk <pellared@hotmail.com> Co-authored-by: Robert Pająk <pellared@hotmail.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
shbieng
added a commit
to shbieng/opentelemetry-go
that referenced
this issue
Aug 26, 2022
…rce (#2139) * fix(2138): add guard to constructOTResources to return an empty resource when attributes are not supplied Fixes: open-telemetry/opentelemetry-go#2138 * Update CHANGELOG.md Co-authored-by: Robert Pająk <pellared@hotmail.com> Co-authored-by: Robert Pająk <pellared@hotmail.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
If you set
OTEL_SERVICE_NAME
, but do not setOTEL_RESOURCE_ATTRIBUTES
anerrMissingValue
occurs.Environment
Steps To Reproduce
Add the following test case to
env_test.go
, and it will fail.constructOTResources is being called with an empty string. We should check the input, and return an empty resource if no attributes are provided.
Expected behavior
No error should occur.
The text was updated successfully, but these errors were encountered: