Add semconv/v1.19.0 #3848

tsloughter · 2023-03-08T18:57:32Z

Opening this so I can then make a PR to go-contrib to update the Lambda semconv used.

codecov · 2023-03-08T19:01:43Z

Codecov Report

Merging #3848 (98fd722) into main (476d00a) will increase coverage by 0.5%.
The diff coverage is 100.0%.

Additional details and impacted files

@@           Coverage Diff           @@
##            main   #3848     +/-   ##
=======================================
+ Coverage   82.2%   82.8%   +0.5%     
=======================================
  Files        175     177      +2     
  Lines      13058   13494    +436     
=======================================
+ Hits       10742   11176    +434     
- Misses      2095    2097      +2     
  Partials     221     221

Impacted Files	Coverage Δ
semconv/internal/v3/http.go	`100.0% <100.0%> (ø)`
semconv/internal/v3/net.go	`100.0% <100.0%> (ø)`

... and 1 file with indirect coverage changes

tsloughter · 2023-03-08T19:34:21Z

Closes #3848

MrAlias · 2023-03-08T20:38:59Z

This will need some work to address the changes in the specification that are breaking the build currently. All the changes should be mentioned in #3842

tsloughter · 2023-03-08T21:30:23Z

Yup, will do once the build works at least. Any ideas about the errors. It can't find HTTPSchemeKey? It doesn't seem to be defined outside of some older semconv versions..

MrAlias · 2023-03-08T23:12:55Z

I'm not sure. Looks like the key is no longer being generated. I looked at the specification, but there is so many layer of indirection I don't know where http.scheme is generated from any more.

Guessing you'll need to track that down and then check that the build tools are correctly parsing that.

tsloughter · 2023-03-08T23:25:05Z

Found it is being tracked in this issue open-telemetry/opentelemetry-specification#3299

Includes adding semconv/internal/v3/ to support the move of the semantic convention HTTPUserAgentKey to the new key UserAgentOriginalKey

internal/tools/semconvkit/templates/httpconv/http.go.tmpl

CHANGELOG.md

Co-authored-by: Robert Pająk <pellared@hotmail.com>

pellared

In general looks good. I think it just needs a little cleanup.

internal/tools/semconvkit/templates/httpconv/http.go.tmpl

semconv/internal/v3/net.go

semconv/internal/v3/net_test.go

semconv/v1.19.0/httpconv/http.go

pellared

👍

Makefile

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/XSAM/otelsql](https://togithub.com/XSAM/otelsql) | require | minor | `v0.21.0` -> `v0.23.0` | | [go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin](https://togithub.com/open-telemetry/opentelemetry-go-contrib) | require | minor | `v0.40.0` -> `v0.42.0` | | [go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho](https://togithub.com/open-telemetry/opentelemetry-go-contrib) | require | minor | `v0.40.0` -> `v0.42.0` | | [go.opentelemetry.io/otel](https://togithub.com/open-telemetry/opentelemetry-go) | require | minor | `v1.14.0` -> `v1.16.0` | | [go.opentelemetry.io/otel/exporters/jaeger](https://togithub.com/open-telemetry/opentelemetry-go) | require | minor | `v1.14.0` -> `v1.16.0` | | [go.opentelemetry.io/otel/exporters/otlp/otlptrace](https://togithub.com/open-telemetry/opentelemetry-go) | require | minor | `v1.14.0` -> `v1.16.0` | | [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc](https://togithub.com/open-telemetry/opentelemetry-go) | require | minor | `v1.14.0` -> `v1.16.0` | | [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp](https://togithub.com/open-telemetry/opentelemetry-go) | require | minor | `v1.14.0` -> `v1.16.0` | | [go.opentelemetry.io/otel/exporters/stdout/stdouttrace](https://togithub.com/open-telemetry/opentelemetry-go) | require | minor | `v1.14.0` -> `v1.16.0` | | [go.opentelemetry.io/otel/sdk](https://togithub.com/open-telemetry/opentelemetry-go) | require | minor | `v1.14.0` -> `v1.16.0` | | [go.opentelemetry.io/otel/trace](https://togithub.com/open-telemetry/opentelemetry-go) | require | minor | `v1.14.0` -> `v1.16.0` | --- ### Release Notes <details> <summary>XSAM/otelsql</summary> ### [`v0.23.0`](https://togithub.com/XSAM/otelsql/releases/tag/v0.23.0) [Compare Source](https://togithub.com/XSAM/otelsql/compare/v0.22.0...v0.23.0) #### 0.23.0 - 2023-05-22 ##### Changed - Upgrade OTel to version `1.16.0/0.39.0`. ([#170](https://togithub.com/XSAM/otelsql/issues/170)) ### [`v0.22.0`](https://togithub.com/XSAM/otelsql/releases/tag/v0.22.0) [Compare Source](https://togithub.com/XSAM/otelsql/compare/v0.21.0...v0.22.0) #### 0.22.0 - 2023-04-28 ##### ⚠️ Notice ⚠️ The minimum supported Go version is `1.19`. ##### Changed - Upgrade OTel to version `1.15.0/0.38.0`. ([#163](https://togithub.com/XSAM/otelsql/issues/163)) ##### Removed - Support for Go `1.18`. Support is now only for Go `1.19` and Go `1.20`. ([#164](https://togithub.com/XSAM/otelsql/issues/164)) </details> <details> <summary>open-telemetry/opentelemetry-go</summary> ### [`v1.16.0`](https://togithub.com/open-telemetry/opentelemetry-go/releases/tag/v1.16.0): /v0.39.0 -- Stable Metric API [Compare Source](https://togithub.com/open-telemetry/opentelemetry-go/compare/v1.15.1...v1.16.0) This release contains the first stable release of the OpenTelemetry Go [metric API]. Our project stability guarantees now apply to the `go.opentelemetry.io/otel/metric` package. See our [versioning policy](VERSIONING.md) for more information about these stability guarantees. ##### What's Changed ##### Added - The `go.opentelemetry.io/otel/semconv/v1.19.0` package. The package contains semantic conventions from the `v1.19.0` version of the OpenTelemetry specification. ([#3848](https://togithub.com/open-telemetry/opentelemetry-go/issues/3848)) - The `go.opentelemetry.io/otel/semconv/v1.20.0` package. The package contains semantic conventions from the `v1.20.0` version of the OpenTelemetry specification. ([#4078](https://togithub.com/open-telemetry/opentelemetry-go/issues/4078)) ##### Changed - Use `strings.Cut()` instead of `string.SplitN()` for better readability and memory use. ([#4049](https://togithub.com/open-telemetry/opentelemetry-go/issues/4049)) ##### Removed - The deprecated `go.opentelemetry.io/otel/metric/instrument` package is removed. Use `go.opentelemetry.io/otel/metric` instead. ([#4055](https://togithub.com/open-telemetry/opentelemetry-go/issues/4055)) ##### Fixed - Fix build for BSD based systems in `go.opentelemetry.io/otel/sdk/resource`. ([#4077](https://togithub.com/open-telemetry/opentelemetry-go/issues/4077)) ##### New Contributors - [@tsloughter](https://togithub.com/tsloughter) made their first contribution in [open-telemetry/opentelemetry-go#3848 - [@Tijmen34](https://togithub.com/Tijmen34) made their first contribution in [open-telemetry/opentelemetry-go#4074 - [@ChillOrb](https://togithub.com/ChillOrb) made their first contribution in [open-telemetry/opentelemetry-go#3677 - [@ChenX1993](https://togithub.com/ChenX1993) made their first contribution in [open-telemetry/opentelemetry-go#4043 - [@andrew-womeldorf](https://togithub.com/andrew-womeldorf) made their first contribution in [open-telemetry/opentelemetry-go#4086 **Full Changelog**: open-telemetry/opentelemetry-go@v1.15.1...v1.16.0 [metric API]: https://pkg.go.dev/go.opentelemetry.io/otel/metric ### [`v1.15.1`](https://togithub.com/open-telemetry/opentelemetry-go/releases/tag/v1.15.1): /v0.38.1 [Compare Source](https://togithub.com/open-telemetry/opentelemetry-go/compare/v1.15.0...v1.15.1) ##### What's Changed ##### Fixed - Remove unused imports from `sdk/resource/host_id_bsd.go` which caused build failures. ([#4040](https://togithub.com/open-telemetry/opentelemetry-go/issues/4040), [#4041](https://togithub.com/open-telemetry/opentelemetry-go/issues/4041)) ##### New Contributors - [@Achooo](https://togithub.com/Achooo) made their first contribution in [open-telemetry/opentelemetry-go#4041 **Full Changelog**: open-telemetry/opentelemetry-go@v1.15.0...v1.15.1 ### [`v1.15.0`](https://togithub.com/open-telemetry/opentelemetry-go/releases/tag/v1.15.0): /v0.38.0 [Compare Source](https://togithub.com/open-telemetry/opentelemetry-go/compare/v1.14.0...v1.15.0) ##### Added - The `go.opentelemetry.io/otel/metric/embedded` package. ([#3916](https://togithub.com/open-telemetry/opentelemetry-go/issues/3916)) - The `Version` function to `go.opentelemetry.io/otel/sdk` to return the SDK version. ([#3949](https://togithub.com/open-telemetry/opentelemetry-go/issues/3949)) - Add a `WithNamespace` option to `go.opentelemetry.io/otel/exporters/prometheus` to allow users to prefix metrics with a namespace. ([#3970](https://togithub.com/open-telemetry/opentelemetry-go/issues/3970)) - The following configuration types were added to `go.opentelemetry.io/otel/metric/instrument` to be used in the configuration of measurement methods. ([#3971](https://togithub.com/open-telemetry/opentelemetry-go/issues/3971)) - The `AddConfig` used to hold configuration for addition measurements - `NewAddConfig` used to create a new `AddConfig` - `AddOption` used to configure an `AddConfig` - The `RecordConfig` used to hold configuration for recorded measurements - `NewRecordConfig` used to create a new `RecordConfig` - `RecordOption` used to configure a `RecordConfig` - The `ObserveConfig` used to hold configuration for observed measurements - `NewObserveConfig` used to create a new `ObserveConfig` - `ObserveOption` used to configure an `ObserveConfig` - `WithAttributeSet` and `WithAttributes` are added to `go.opentelemetry.io/otel/metric/instrument`. They return an option used during a measurement that defines the attribute Set associated with the measurement. ([#3971](https://togithub.com/open-telemetry/opentelemetry-go/issues/3971)) - The `Version` function to `go.opentelemetry.io/otel/exporters/otlp/otlpmetric` to return the OTLP metrics client version. ([#3956](https://togithub.com/open-telemetry/opentelemetry-go/issues/3956)) - The `Version` function to `go.opentelemetry.io/otel/exporters/otlp/otlptrace` to return the OTLP trace client version. ([#3956](https://togithub.com/open-telemetry/opentelemetry-go/issues/3956)) ##### Changed - The `Extrema` in `go.opentelemetry.io/otel/sdk/metric/metricdata` is redefined with a generic argument of `[N int64 | float64]`. ([#3870](https://togithub.com/open-telemetry/opentelemetry-go/issues/3870)) - Update all exported interfaces from `go.opentelemetry.io/otel/metric` to embed their corresponding interface from `go.opentelemetry.io/otel/metric/embedded`. This adds an implementation requirement to set the interface default behavior for unimplemented methods. ([#3916](https://togithub.com/open-telemetry/opentelemetry-go/issues/3916)) - Move No-Op implementation from `go.opentelemetry.io/otel/metric` into its own package `go.opentelemetry.io/otel/metric/noop`. ([#3941](https://togithub.com/open-telemetry/opentelemetry-go/issues/3941)) - `metric.NewNoopMeterProvider` is replaced with `noop.NewMeterProvider` - Add all the methods from `"go.opentelemetry.io/otel/trace".SpanContext` to `bridgeSpanContext` by embedding `otel.SpanContext` in `bridgeSpanContext`. ([#3966](https://togithub.com/open-telemetry/opentelemetry-go/issues/3966)) - Wrap `UploadMetrics` error in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/` to improve error message when encountering generic grpc errors. ([#3974](https://togithub.com/open-telemetry/opentelemetry-go/issues/3974)) - The measurement methods for all instruments in `go.opentelemetry.io/otel/metric/instrument` accept an option instead of the variadic `"go.opentelemetry.io/otel/attribute".KeyValue`. ([#3971](https://togithub.com/open-telemetry/opentelemetry-go/issues/3971)) - The `Int64Counter.Add` method now accepts `...AddOption` - The `Float64Counter.Add` method now accepts `...AddOption` - The `Int64UpDownCounter.Add` method now accepts `...AddOption` - The `Float64UpDownCounter.Add` method now accepts `...AddOption` - The `Int64Histogram.Record` method now accepts `...RecordOption` - The `Float64Histogram.Record` method now accepts `...RecordOption` - The `Int64Observer.Observe` method now accepts `...ObserveOption` - The `Float64Observer.Observe` method now accepts `...ObserveOption` - The `Observer` methods in `go.opentelemetry.io/otel/metric` accept an option instead of the variadic `"go.opentelemetry.io/otel/attribute".KeyValue`. ([#3971](https://togithub.com/open-telemetry/opentelemetry-go/issues/3971)) - The `Observer.ObserveInt64` method now accepts `...ObserveOption` - The `Observer.ObserveFloat64` method now accepts `...ObserveOption` - Move global metric back to `go.opentelemetry.io/otel/metric/global` from `go.opentelemetry.io/otel`. ([#3986](https://togithub.com/open-telemetry/opentelemetry-go/issues/3986)) ##### Fixed - `TracerProvider` allows calling `Tracer()` while it's shutting down. It used to deadlock. ([#3924](https://togithub.com/open-telemetry/opentelemetry-go/issues/3924)) - Use the SDK version for the Telemetry SDK resource detector in `go.opentelemetry.io/otel/sdk/resource`. ([#3949](https://togithub.com/open-telemetry/opentelemetry-go/issues/3949)) - Fix a data race in `SpanProcessor` returned by `NewSimpleSpanProcessor` in `go.opentelemetry.io/otel/sdk/trace`. ([#3951](https://togithub.com/open-telemetry/opentelemetry-go/issues/3951)) - Automatically figure out the default aggregation with `aggregation.Default`. ([#3967](https://togithub.com/open-telemetry/opentelemetry-go/issues/3967)) ##### Deprecated - The `go.opentelemetry.io/otel/metric/instrument` package is deprecated. Use the equivalent types added to `go.opentelemetry.io/otel/metric` instead. ([#4018](https://togithub.com/open-telemetry/opentelemetry-go/issues/4018)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/infratographer/x).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc](https://togithub.com/open-telemetry/opentelemetry-go) | require | minor | `v0.38.0` -> `v0.39.0` | | [go.opentelemetry.io/otel/exporters/otlp/otlptrace](https://togithub.com/open-telemetry/opentelemetry-go) | require | minor | `v1.15.0` -> `v1.16.0` | | [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc](https://togithub.com/open-telemetry/opentelemetry-go) | require | minor | `v1.15.0` -> `v1.16.0` | | [go.opentelemetry.io/otel/exporters/prometheus](https://togithub.com/open-telemetry/opentelemetry-go) | require | minor | `v0.38.0` -> `v0.39.0` | --- ### Release Notes <details> <summary>open-telemetry/opentelemetry-go</summary> ### [`v1.16.0`](https://togithub.com/open-telemetry/opentelemetry-go/releases/tag/v1.16.0): /v0.39.0 -- Stable Metric API [Compare Source](https://togithub.com/open-telemetry/opentelemetry-go/compare/v1.15.1...v1.16.0) This release contains the first stable release of the OpenTelemetry Go [metric API]. Our project stability guarantees now apply to the `go.opentelemetry.io/otel/metric` package. See our [versioning policy](VERSIONING.md) for more information about these stability guarantees. ##### What's Changed ##### Added - The `go.opentelemetry.io/otel/semconv/v1.19.0` package. The package contains semantic conventions from the `v1.19.0` version of the OpenTelemetry specification. ([#3848](https://togithub.com/open-telemetry/opentelemetry-go/issues/3848)) - The `go.opentelemetry.io/otel/semconv/v1.20.0` package. The package contains semantic conventions from the `v1.20.0` version of the OpenTelemetry specification. ([#4078](https://togithub.com/open-telemetry/opentelemetry-go/issues/4078)) ##### Changed - Use `strings.Cut()` instead of `string.SplitN()` for better readability and memory use. ([#4049](https://togithub.com/open-telemetry/opentelemetry-go/issues/4049)) ##### Removed - The deprecated `go.opentelemetry.io/otel/metric/instrument` package is removed. Use `go.opentelemetry.io/otel/metric` instead. ([#4055](https://togithub.com/open-telemetry/opentelemetry-go/issues/4055)) ##### Fixed - Fix build for BSD based systems in `go.opentelemetry.io/otel/sdk/resource`. ([#4077](https://togithub.com/open-telemetry/opentelemetry-go/issues/4077)) ##### New Contributors - [@tsloughter](https://togithub.com/tsloughter) made their first contribution in [open-telemetry/opentelemetry-go#3848 - [@Tijmen34](https://togithub.com/Tijmen34) made their first contribution in [open-telemetry/opentelemetry-go#4074 - [@ChillOrb](https://togithub.com/ChillOrb) made their first contribution in [open-telemetry/opentelemetry-go#3677 - [@ChenX1993](https://togithub.com/ChenX1993) made their first contribution in [open-telemetry/opentelemetry-go#4043 - [@andrew-womeldorf](https://togithub.com/andrew-womeldorf) made their first contribution in [open-telemetry/opentelemetry-go#4086 **Full Changelog**: open-telemetry/opentelemetry-go@v1.15.1...v1.16.0 [metric API]: https://pkg.go.dev/go.opentelemetry.io/otel/metric ### [`v1.15.1`](https://togithub.com/open-telemetry/opentelemetry-go/releases/tag/v1.15.1): /v0.38.1 [Compare Source](https://togithub.com/open-telemetry/opentelemetry-go/compare/v1.15.0...v1.15.1) ##### What's Changed ##### Fixed - Remove unused imports from `sdk/resource/host_id_bsd.go` which caused build failures. ([#4040](https://togithub.com/open-telemetry/opentelemetry-go/issues/4040), [#4041](https://togithub.com/open-telemetry/opentelemetry-go/issues/4041)) ##### New Contributors - [@Achooo](https://togithub.com/Achooo) made their first contribution in [open-telemetry/opentelemetry-go#4041 **Full Changelog**: open-telemetry/opentelemetry-go@v1.15.0...v1.15.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-feature/flagd).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

tsloughter requested review from jmacd, MrAlias, Aneurysm9, evantorrie, XSAM, dashpole, MadVikingGod, pellared, hanyuancheung and dmathieu as code owners March 8, 2023 18:57

tsloughter force-pushed the semconv-v1.19.0 branch from f95e81b to 8d7f53c Compare March 28, 2023 21:57

Add semconv/v1.19.0

79d25f5

Includes adding semconv/internal/v3/ to support the move of the semantic convention HTTPUserAgentKey to the new key UserAgentOriginalKey

tsloughter force-pushed the semconv-v1.19.0 branch from 8d7f53c to 79d25f5 Compare March 28, 2023 23:13

pellared reviewed Mar 29, 2023

View reviewed changes

internal/tools/semconvkit/templates/httpconv/http.go.tmpl Outdated Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

pellared and others added 4 commits April 12, 2023 08:43

Merge branch 'main' into semconv-v1.19.0

d66d04f

Update CHANGELOG.md

aff86bc

Co-authored-by: Robert Pająk <pellared@hotmail.com>

format http.go.tmpl using tabs instead of spaces

24fba17

Merge branch 'main' into semconv-v1.19.0

28e27cf

pellared reviewed Apr 27, 2023

View reviewed changes

internal/tools/semconvkit/templates/httpconv/http.go.tmpl Show resolved Hide resolved

semconv/internal/v3/net.go Outdated Show resolved Hide resolved

semconv/internal/v3/net_test.go Outdated Show resolved Hide resolved

semconv/v1.19.0/httpconv/http.go Show resolved Hide resolved

update http.go.tmpl to use v3 of semconv/internal

4b13fdd

pellared approved these changes Apr 27, 2023

View reviewed changes

Merge branch 'main' into semconv-v1.19.0

200f7de

Aneurysm9 approved these changes Apr 27, 2023

View reviewed changes

Makefile Outdated Show resolved Hide resolved

Generate attribute_group.go

ff426ad

Merge branch 'main' into semconv-v1.19.0

bb61e3c

dmathieu approved these changes May 8, 2023

View reviewed changes

MrAlias added 2 commits May 8, 2023 07:48

Merge branch 'main' into semconv-v1.19.0

8c8d023

Merge branch 'main' into semconv-v1.19.0

98fd722

MrAlias merged commit b243b6e into open-telemetry:main May 8, 2023
21 checks passed

This was referenced May 17, 2023

Generate v1.19.0 semconv #3842

Closed

Release v1.16.0/v0.39.0 -- Stable Metric API #4100

Merged

renovate bot mentioned this pull request Apr 5, 2024

fix(deps): update opentelemetry-go monorepo PlanVX/aweme#112

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add semconv/v1.19.0 #3848

Add semconv/v1.19.0 #3848

tsloughter commented Mar 8, 2023

codecov bot commented Mar 8, 2023 •

edited

tsloughter commented Mar 8, 2023

MrAlias commented Mar 8, 2023

tsloughter commented Mar 8, 2023

MrAlias commented Mar 8, 2023

tsloughter commented Mar 8, 2023

pellared left a comment

pellared left a comment

Add semconv/v1.19.0 #3848

Add semconv/v1.19.0 #3848

Conversation

tsloughter commented Mar 8, 2023

codecov bot commented Mar 8, 2023 • edited

Codecov Report

tsloughter commented Mar 8, 2023

MrAlias commented Mar 8, 2023

tsloughter commented Mar 8, 2023

MrAlias commented Mar 8, 2023

tsloughter commented Mar 8, 2023

pellared left a comment

Choose a reason for hiding this comment

pellared left a comment

Choose a reason for hiding this comment

codecov bot commented Mar 8, 2023 •

edited