Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WithoutCounterSuffixes option in the prometheus exporter #4306

Merged
merged 1 commit into from Jul 14, 2023
Merged

Add WithoutCounterSuffixes option in the prometheus exporter #4306

merged 1 commit into from Jul 14, 2023

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole force-pushed the disable_suffix_prom_exporter branch from 7255c97 to 1cbfa23 Compare July 11, 2023 14:23
@dashpole dashpole added pkg:exporter:prometheus Related to the Prometheus exporter package enhancement New feature or request labels Jul 13, 2023
@dashpole dashpole marked this pull request as ready for review July 13, 2023 15:12
@dashpole
Copy link
Contributor Author

This is now ready for review

@codecov
Copy link

codecov bot commented Jul 13, 2023 •
edited

Codecov Report

Merging #4306 (98cb7d5) into main (55fb2bb) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

❗ Current head 98cb7d5 differs from pull request most recent head d481b7d. Consider uploading reports for the commit d481b7d to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4306     +/-   ##
=======================================
- Coverage   83.6%   83.6%   -0.1%     
=======================================
  Files        183     183             
  Lines      14221   14227      +6     
=======================================
+ Hits       11895   11899      +4     
- Misses      2100    2102      +2     
  Partials     226     226
Impacted Files Coverage Δ
exporters/prometheus/config.go 100.0% <100.0%> (ø)
exporters/prometheus/exporter.go 86.5% <100.0%> (+<0.1%) ⬆️

... and 1 file with indirect coverage changes

howardjohn
howardjohn approved these changes Jul 13, 2023
View reviewed changes
Copy link

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I pulled this into our local dev branch and this works as I expected and (will) unblock our adoption of otel. 👍

@howardjohn howardjohn mentioned this pull request Jul 13, 2023
Merged
pellared
pellared reviewed Jul 14, 2023
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@dashpole
Add WithoutCounterSuffixes option in go.opentelemetry.io/otel/exporte…
d481b7d 
…rs/prometheus to disable addition of _total suffixes
@dashpole dashpole force-pushed the disable_suffix_prom_exporter branch from a19cd67 to d481b7d Compare July 14, 2023 15:42
@pellared pellared merged commit 03b8c47 into open-telemetry:main Jul 14, 2023
22 checks passed
pellared added a commit to pellared/opentelemetry-go that referenced this pull request Jul 14, 2023
@pellared
Fix changelog entry number for open-telemetry#4306
5317aca
MrAlias added a commit to MrAlias/opentelemetry-go that referenced this pull request Jul 14, 2023
@MrAlias
Fix missing PR number in changelog
11a5114 
Follow up from open-telemetry#4306
@MrAlias MrAlias mentioned this pull request Jul 14, 2023
Closed
pellared added a commit that referenced this pull request Jul 14, 2023
@pellared
Fix changelog entry number for #4306 (#4314)
3e203ac
@MrAlias MrAlias modified the milestone: Metric SDK v0.40.0 Aug 3, 2023
@MrAlias MrAlias added this to the v1.17.0/v0.40.0 milestone Aug 3, 2023
@MrAlias MrAlias mentioned this pull request Aug 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn approved these changes

@pellared pellared pellared approved these changes

@MrAlias MrAlias MrAlias approved these changes

@hanyuancheung hanyuancheung hanyuancheung approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9 Aneurysm9 is a code owner

@evantorrie evantorrie Awaiting requested review from evantorrie evantorrie is a code owner

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod MadVikingGod is a code owner

@dmathieu dmathieu Awaiting requested review from dmathieu dmathieu is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request pkg:exporter:prometheus Related to the Prometheus exporter package
Projects
None yet
Milestone
v1.17.0/v0.40.0
Development

Successfully merging this pull request may close these issues.

Allow disabling additional suffixes in prometheus exporter
5 participants
@dashpole @howardjohn @pellared @MrAlias @hanyuancheung