Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document PR commits preference in CONTRIBUTING.md #4701

Closed
pellared opened this issue Nov 9, 2023 · 1 comment · Fixed by #4704
Closed

Document PR commits preference in CONTRIBUTING.md #4701

pellared opened this issue Nov 9, 2023 · 1 comment · Fixed by #4704
Assignees
@mikeblum

Comments

@pellared
Copy link
Member

pellared commented Nov 9, 2023 •
edited

Checked CONTRIBUTING.md but I wasn't sure if squashing was enabled or not for PRs so I did it manually. Thanks for pushing up your suggestions!

Originally posted by @mikeblum in #4699 (comment)

I think we should document that we prefer if people just add commits, including merge commits and avoid force pushes. Rewriting history makes reviewing harder. We can even say that we do "squash merge".
@mikeblum
Copy link
Contributor

mikeblum commented Nov 9, 2023

🤚 I'll update the docs

mikeblum added a commit to mikeblum/opentelemetry-go that referenced this issue Nov 9, 2023
@mikeblum
Document PR commits preference in CONTRIBUTING.md (open-telemetry#4701)
7a53015
@mikeblum mikeblum mentioned this issue Nov 9, 2023
Merged
mikeblum added a commit to mikeblum/opentelemetry-go that referenced this issue Nov 9, 2023
@mikeblum
docs: Document PR commits preference in CONTRIBUTING.md (open-telemet…
31f2b63 
…ry#4701)
mikeblum added a commit to mikeblum/opentelemetry-go that referenced this issue Nov 12, 2023
@mikeblum
Merge branch 'main' into open-telemetryGH-4701-contributing-pr-commit…
251601c 
…-pref
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikeblum mikeblum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document PR commits preference in CONTRIBUTING.md mikeblum/opentelemetry-go
2 participants
@mikeblum @pellared