-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change name of ProbabilitySampler to TraceIdRatioBased #1115
Conversation
* Modify behavior to ignore parent span * Add test for inclusivity property on TraceIdRatioBased sampler * Modify tests in `trace_test.go` to reflect change in parent span behavior
Codecov Report
@@ Coverage Diff @@
## master #1115 +/- ##
========================================
- Coverage 77.1% 77.1% -0.1%
========================================
Files 133 133
Lines 7109 7106 -3
========================================
- Hits 5488 5483 -5
Misses 1371 1371
- Partials 250 252 +2
|
Original issue #1083 says to change the name to I guess it is more congruent with |
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…y#1115) * Change name of ProbabilitySampler to TraceIdRatioBased * Modify behavior to ignore parent span * Add test for inclusivity property on TraceIdRatioBased sampler * Modify tests in `trace_test.go` to reflect change in parent span behavior * Add to CHANGELOG * Satisfy golint * Update CHANGELOG.md Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Update the examples to use the current API for configuring production sampling. These names were changed a couple of years ago. open-telemetry/opentelemetry-go#1115 open-telemetry/opentelemetry-go#1153
fix #1083
trace_test.go
to reflect change in parent span behavior