Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Makefile to prevent find complaining due to missing directory parameter #1116

Merged

Conversation

evantorrie
Copy link
Contributor

Fix dependabot-check Makefile syntax for find. Previously missing first argument for starting directory, which resulted in find throwing an error about find: illegal option -- t on my machine.

@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #1116 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1116     +/-   ##
========================================
- Coverage    77.2%   77.1%   -0.2%     
========================================
  Files         133     133             
  Lines        7109    7108      -1     
========================================
- Hits         5493    5485      -8     
- Misses       1367    1372      +5     
- Partials      249     251      +2     
Impacted Files Coverage Δ
api/trace/api.go 54.0% <0.0%> (-9.7%) ⬇️
api/trace/tracetest/provider.go 90.4% <0.0%> (-9.6%) ⬇️
exporters/trace/jaeger/reconnecting_udp_client.go 88.5% <0.0%> (-2.3%) ⬇️
sdk/trace/provider.go 85.8% <0.0%> (+0.3%) ⬆️

@MrAlias MrAlias merged commit 440c4bd into open-telemetry:master Sep 2, 2020
@evantorrie evantorrie deleted the fix-makefile-dependabot-find branch September 10, 2020 15:48
evantorrie added a commit to evantorrie/opentelemetry-go that referenced this pull request Sep 10, 2020
…-telemetry#1116)

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants