Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't consider unset env var to be an error during resource detection #1170

Merged
merged 3 commits into from Sep 14, 2020

Conversation

matej-g
Copy link
Contributor

@matej-g matej-g commented Sep 13, 2020

In line with the suggestion in the issue #1114 and considering the text of the specification with regards to resource detection

Note the failure to detect any resource information MUST NOT be considered an error, whereas an error that occurs during an attempt to detect resource information SHOULD be considered an error.

The failure to set environment variable for OTEL_RESOURCE_ATTRIBUTES should not result in an error.

Resolves #1170

@codecov
Copy link

codecov bot commented Sep 13, 2020

Codecov Report

Merging #1170 into master will decrease coverage by 0.3%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1170     +/-   ##
========================================
- Coverage    78.2%   77.9%   -0.4%     
========================================
  Files         135     135             
  Lines        7163    7192     +29     
========================================
  Hits         5603    5603             
- Misses       1317    1346     +29     
  Partials      243     243             
Impacted Files Coverage Δ
sdk/resource/auto.go 0.0% <ø> (ø)
sdk/resource/env.go 100.0% <ø> (ø)
label/type_string.go 12.5% <0.0%> (-37.5%) ⬇️
sdk/export/metric/exportkind_string.go 64.2% <0.0%> (-35.8%) ⬇️
api/metric/kind_string.go 16.6% <0.0%> (-33.4%) ⬇️
api/metric/numberkind_string.go 25.0% <0.0%> (-25.0%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants