Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge otel into one file and add package doc #1176

Merged
merged 1 commit into from Sep 14, 2020
Merged

Merge otel into one file and add package doc #1176

merged 1 commit into from Sep 14, 2020

Conversation

rakyll
Copy link
Contributor

@rakyll rakyll commented Sep 14, 2020

No need to split a tiny package into multiple files. Also adding package doc for the otel package.

No need to split a tiny package into multiple files. Also adding package doc for the otel package.
@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #1176 into master will increase coverage by 0.3%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1176     +/-   ##
========================================
+ Coverage    77.9%   78.2%   +0.3%     
========================================
  Files         135     135             
  Lines        7192    7163     -29     
========================================
- Hits         5604    5603      -1     
+ Misses       1344    1317     -27     
+ Partials      244     243      -1     
Impacted Files Coverage Δ
sdk/trace/batch_span_processor.go 78.5% <0.0%> (-1.1%) ⬇️
api/metric/numberkind_string.go 50.0% <0.0%> (+25.0%) ⬆️
api/metric/kind_string.go 50.0% <0.0%> (+33.3%) ⬆️
sdk/export/metric/exportkind_string.go 100.0% <0.0%> (+35.7%) ⬆️
label/type_string.go 50.0% <0.0%> (+37.5%) ⬆️

@Aneurysm9 Aneurysm9 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 14, 2020
@Aneurysm9 Aneurysm9 merged commit 3de7a07 into open-telemetry:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants