Rename *Provider names #1190
Merged
Rename *Provider names #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is overlap in naming with MeterProviders and TracerProviders. This is means the specification is not implemented and these types can not exist in the same package (open-telemetry#1179). This makes each type and related functions and types explicit.
Codecov Report
@@ Coverage Diff @@
## master #1190 +/- ##
========================================
+ Coverage 76.3% 77.0% +0.6%
========================================
Files 134 135 +1
Lines 5720 5867 +147
========================================
+ Hits 4368 4521 +153
+ Misses 1107 1104 -3
+ Partials 245 242 -3
|
MrAlias
added
area:metrics
MrAlias
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey and
XSAM
as code owners
jmacd
approved these changes
Sep 23, 2020
Aneurysm9
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is overlap in naming with MeterProviders and TracerProviders. This is means the specification is not implemented and these types can not exist in the same package (#1179). This makes each type and related functions and types explicit.
Part of #1179 and #964