Remove semantic convention for http status text #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpackingham
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1194 +/- ##
========================================
- Coverage 76.3% 76.2% -0.1%
========================================
Files 134 134
Lines 5723 5720 -3
========================================
- Hits 4367 4364 -3
Misses 1112 1112
Partials 244 244
|
MrAlias
approved these changes
Sep 22, 2020
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
XSAM
approved these changes
Sep 23, 2020
Aneurysm9
approved these changes
Sep 23, 2020
jmacd
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey everyone, first issue! Hoping I understood it correctly and followed the guidelines. I removed the http status text semantic convention as mentioned in this PR on the opentelemetry specification.
Part of issue #1193