Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change resource.New() to use functional options; add builtin attributes for (host.*, telemetry.sdk.*) #1235

Merged
merged 16 commits into from
Oct 31, 2020
Merged

Change resource.New() to use functional options; add builtin attributes for (host.*, telemetry.sdk.*) #1235

merged 16 commits into from
Oct 31, 2020

Commits on Oct 9, 2020

  1. Add a resource.Configure() with functional options

    @jmacd
    jmacd committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    557c162 View commit details
    Browse the repository at this point in the history

  2. Add a changelog

    @jmacd
    jmacd committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    a0c5f4d View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2020

  1. Add tests for builtin resources

    @jmacd
    jmacd committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    f0a7298 View commit details
    Browse the repository at this point in the history

  2. Rename to WithoutBuiltin

    @jmacd
    jmacd committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    ca7311f View commit details
    Browse the repository at this point in the history

  3. Add new test; restore environment after tests

    @jmacd
    jmacd committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    1015745 View commit details
    Browse the repository at this point in the history

  4. Upstream

    @jmacd
    jmacd committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    d547ca3 View commit details
    Browse the repository at this point in the history

  5. Apply feedback

    @jmacd
    jmacd committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    5fd94db View commit details
    Browse the repository at this point in the history

  6. Changelog

    @jmacd
    jmacd committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    91b6a51 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2020

  1. Apply suggestions from code review 

    ❤️

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
    @jmacd @MrAlias
    jmacd and MrAlias committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    e1f4ee3 View commit details
    Browse the repository at this point in the history

  2. Upstream

    @jmacd
    jmacd committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    15d2465 View commit details
    Browse the repository at this point in the history

  3. Comment edits

    @jmacd
    jmacd committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    345557e View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2020

  1. Merge branch 'master' into jmacd/resource_conf

    @jmacd
    jmacd committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    99acc3c View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2020

  1. Upstream

    @jmacd
    jmacd committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    c0ad125 View commit details
    Browse the repository at this point in the history

  2. Rename New, former method NewFromAttributes

    @jmacd
    jmacd committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    5788aea View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2020

  1. NewFromAttributes->NewWithAttributes

    @jmacd
    jmacd committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    0efcca6 View commit details
    Browse the repository at this point in the history

  2. Upstream

    @jmacd
    jmacd committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    3f563e5 View commit details
    Browse the repository at this point in the history