Update documentation for the OTLP exporter #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update package documentation to reflect the contents of the package. Fix lint issues by adding documentation for all exported types. Update file comment location in otlp.go so golint does not interpret it as package documentation.
MrAlias
added
documentation
MrAlias
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey and
XSAM
as code owners
Aneurysm9
approved these changes
Oct 11, 2020
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Codecov Report
@@ Coverage Diff @@
## master #1242 +/- ##
========================================
- Coverage 76.7% 76.7% -0.1%
========================================
Files 130 130
Lines 5828 5828
========================================
- Hits 4475 4471 -4
- Misses 1105 1110 +5
+ Partials 248 247 -1
|
XSAM
approved these changes
Oct 12, 2020
AzfaarQureshi
pushed a commit
to open-o11y/opentelemetry-go
that referenced
this pull request
Dec 3, 2020
* Update documentation for the OTLP exporter Update package documentation to reflect the contents of the package. Fix lint issues by adding documentation for all exported types. Update file comment location in otlp.go so golint does not interpret it as package documentation. * Apply suggestions from code review Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update package documentation to reflect the contents of the package.
Fix lint issues by adding documentation for all exported types.
Update file comment location in otlp.go so golint does not interpret it as package documentation.