Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for otel/oteltest #1248

Merged
merged 3 commits into from
Oct 13, 2020

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Oct 13, 2020

Add documentation to exported functions, types, and methods that had none.

Update existing method documentation to wrap consistently and fix grammatical errors.

Update package documentation.

Add documentation to exported functions, types, and methods that had
none.

Update existing documentation to wrap consistently and fix grammatical
errors.
@MrAlias MrAlias added documentation Provides helpful information Skip Changelog PRs that do not require a CHANGELOG.md entry labels Oct 13, 2020
@MrAlias MrAlias self-assigned this Oct 13, 2020
@codecov
Copy link

codecov bot commented Oct 13, 2020

Codecov Report

Merging #1248 into master will decrease coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1248     +/-   ##
========================================
- Coverage    76.7%   76.7%   -0.1%     
========================================
  Files         130     130             
  Lines        5828    5828             
========================================
- Hits         4475    4471      -4     
- Misses       1105    1110      +5     
+ Partials      248     247      -1     
Impacted Files Coverage Δ
oteltest/config.go 94.4% <ø> (ø)
oteltest/mock_span.go 12.5% <ø> (ø)
oteltest/span.go 97.2% <ø> (ø)
oteltest/tracer.go 100.0% <ø> (ø)
oteltest/provider.go 100.0% <100.0%> (ø)
sdk/trace/batch_span_processor.go 74.1% <0.0%> (-4.4%) ⬇️

@MrAlias MrAlias merged commit 5c21e88 into open-telemetry:master Oct 13, 2020
@MrAlias MrAlias deleted the oteltest-lint branch October 13, 2020 19:28
AzfaarQureshi pushed a commit to open-o11y/opentelemetry-go that referenced this pull request Dec 3, 2020
* Fix lint issues in `otel/oteltest`

Add documentation to exported functions, types, and methods that had
none.

Update existing documentation to wrap consistently and fix grammatical
errors.

* Update oteltest package documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Provides helpful information Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants