Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix golint error of package comment form #1487

Merged
merged 2 commits into from
Feb 4, 2021
Merged

Fix golint error of package comment form #1487

merged 2 commits into from
Feb 4, 2021

Conversation

wgliang
Copy link
Member

@wgliang wgliang commented Jan 23, 2021

Run golint ./... | grep "Package ", we can get like:

bridge/opentracing/doc.go:15:1: package comment should be of the form "Package opentracing ..."
bridge/opentracing/migration/api.go:15:1: package comment should be of the form "Package migration ..."
exporters/trace/jaeger/reconnecting_udp_client.go:1:1: package comment should be of the form "Package jaeger ..."
sdk/export/trace/tracetest/test.go:15:1: package comment should be of the form "Package tracetest ..."

This PR just fix this error package comment form.

XSAM
XSAM approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XSAM XSAM added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 25, 2021
Base automatically changed from master to main January 29, 2021 19:39
@wgliang
Copy link
Member Author

wgliang commented Feb 4, 2021

Who can merge this PR?

@MrAlias MrAlias merged commit 186c295 into open-telemetry:main Feb 4, 2021
@MrAlias MrAlias mentioned this pull request Feb 12, 2021
Merged
ldelossa pushed a commit to ldelossa/opentelemetry-go that referenced this pull request Mar 5, 2021
@wgliang @MrAlias @ldelossa
Fix golint error of package comment form (open-telemetry#1487)
2278ab6 
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
This was referenced Jun 16, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole approved these changes

@XSAM XSAM XSAM approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie

@jmacd jmacd Awaiting requested review from jmacd

@lizthegrey lizthegrey Awaiting requested review from lizthegrey

@MrAlias MrAlias Awaiting requested review from MrAlias MrAlias is a code owner

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wgliang @dashpole @XSAM @MrAlias