-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Improvement - Error strings should not be capitalized #1488
Code Improvement - Error strings should not be capitalized #1488
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1488 +/- ##
=====================================
Coverage 79.0% 79.0%
=====================================
Files 127 127
Lines 6683 6683
=====================================
Hits 5280 5280
Misses 1148 1148
Partials 255 255
|
Good catch. I found there are still many codes that have such issues. Should we also fix these parts? e.g., opentelemetry-go/exporters/otlp/otlphttp/driver.go Lines 196 to 199 in c066f15
|
@XSAM Sure. I will fix the current errors and add the linter check to ensure that it will not continue to occur in the future. |
32817ca
to
b8c2957
Compare
Done. |
/ping @XSAM and anyone who needs to review PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Who can merge this PR? |
…metry#1488) Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Code Improvement - Error strings should not be capitalized
https://github.com/golang/go/wiki/CodeReviewComments#error-strings