Remove build flags for runtime/trace support #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The minimum version of Go this project supports is 1.14 meaning that all supported versions of Go support the runtime/trace package. Remove specific build overrides for versions of Go prior to 1.11 that are not supported by this project.
MrAlias
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
lizthegrey and
XSAM
as code owners
lizthegrey
approved these changes
Jan 29, 2021
evantorrie
approved these changes
Jan 29, 2021
XSAM
approved these changes
Jan 29, 2021
Codecov Report
@@ Coverage Diff @@
## main #1498 +/- ##
=======================================
- Coverage 79.0% 79.0% -0.1%
=======================================
Files 128 127 -1
Lines 6685 6683 -2
=======================================
- Hits 5282 5280 -2
Misses 1148 1148
Partials 255 255
|
Merged
ldelossa
pushed a commit
to ldelossa/opentelemetry-go
that referenced
this pull request
Mar 5, 2021
The minimum version of Go this project supports is 1.14 meaning that all supported versions of Go support the runtime/trace package. Remove specific build overrides for versions of Go prior to 1.11 that are not supported by this project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minimum version of Go this project supports is 1.14 meaning that all supported versions of Go support the runtime/trace package. Remove specific build overrides for versions of Go prior to 1.11 that are not supported by this project.
Superseeds #1469