Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move InstrumentKind into the new metric/sdkapi package #2091

Merged
merged 11 commits into from
Aug 11, 2021

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Jul 15, 2021

This moves the InstrumentKind type into the metric/sdkapi package, to remove it from user-facing documentation in the metric package.

Part of #2090.

@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #2091 (d5d7360) into main (1cb5cdc) will not change coverage.
The diff coverage is 73.9%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2091   +/-   ##
=====================================
  Coverage   72.6%   72.6%           
=====================================
  Files        176     177    +1     
  Lines      12000   12000           
=====================================
  Hits        8719    8719           
  Misses      3043    3043           
  Partials     238     238           
Impacted Files Coverage Δ
...rs/otlp/otlpmetric/internal/otlpmetrictest/data.go 0.0% <0.0%> (ø)
...tlp/otlpmetric/internal/otlpmetrictest/otlptest.go 0.0% <0.0%> (ø)
metric/metric_instrument.go 86.4% <ø> (-1.3%) ⬇️
metric/sdkapi/instrumentkind_string.go 40.0% <ø> (ø)
metric/metric.go 56.4% <80.0%> (ø)
bridge/opencensus/exporter.go 100.0% <100.0%> (ø)
metric/sdkapi/instrumentkind.go 100.0% <100.0%> (ø)
sdk/export/metric/metric.go 41.6% <100.0%> (ø)
sdk/metric/aggregator/aggregator.go 100.0% <100.0%> (ø)
sdk/metric/aggregator/aggregatortest/test.go 85.4% <100.0%> (ø)
... and 2 more

@jmacd jmacd added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 15, 2021
@jmacd jmacd removed the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 19, 2021
@MrAlias MrAlias merged commit df384a9 into open-telemetry:main Aug 11, 2021
@jmacd jmacd deleted the jmacd/move_instrument_kind branch October 1, 2021 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants