Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove several metrics test helpers #2105

Merged
merged 8 commits into from
Jul 21, 2021

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Jul 20, 2021

Fixes #872.

This removes two test helpers that could be easily replaced by calls into the better-developed test helpers in sdk/metric/processor/processortest. The replacements are equivalent except for a single test that was removed because it was difficult to replace and offered little extra test coverage.

Adds (processortest.Processor).Reset() helper method.

@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #2105 (f323a4d) into main (4935949) will increase coverage by 0.2%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2105     +/-   ##
=======================================
+ Coverage   72.8%   73.1%   +0.2%     
=======================================
  Files        166     165      -1     
  Lines       8188    8158     -30     
=======================================
+ Hits        5966    5968      +2     
+ Misses      1992    1961     -31     
+ Partials     230     229      -1     
Impacted Files Coverage Δ
sdk/metric/processor/processortest/test.go 89.8% <100.0%> (+<0.1%) ⬆️
exporters/jaeger/jaeger.go 94.2% <0.0%> (+1.1%) ⬆️
exporters/stdout/stdoutmetric/metric.go 80.0% <0.0%> (+1.4%) ⬆️
sdk/metric/aggregator/aggregatortest/test.go 86.8% <0.0%> (+2.0%) ⬆️

exporters/otlp/otlpmetric/go.sum Outdated Show resolved Hide resolved
@Aneurysm9 Aneurysm9 merged commit d57c5a5 into open-telemetry:main Jul 21, 2021
@jmacd jmacd deleted the jmacd/metric_test_cleanup branch July 22, 2021 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve metric test helpers for instrumentation
3 participants