rename Log and Logf interface to AddEvent and AddEventf. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rghetia
commented
Jun 24, 2019
rghetia
commented
- also removed log package.
- also remove log package.
rghetia
requested review from
bogdandrutu,
pjanotti,
sjkaris and
tedsuo
as code owners
bogdandrutu
reviewed
Jun 24, 2019
api/trace/span.go
Outdated
| @@ -167,12 +166,24 @@ func (sp *span) Tracer() Tracer { | |||
| return sp.tracer | |||
| } | |||
|
|
|||
| func (sp *span) Log(ctx context.Context, msg string, args ...core.KeyValue) { | |||
| log.With(sp).Log(ctx, msg, args...) | |||
| func (sp *span) AddEvent(ctx context.Context, msg string, attributes ...core.KeyValue) { | |||
There was a problem hiding this comment.
See how we solve this in Java. We have an interface called Event that can be implemented as "EventF" or as "EventString" so the main Span Interface does not have to provide all these variants.
- Event can be created using Event specific interface.
jmacd
approved these changes
Jun 25, 2019
I have started to separate this morning. |
|
@bogdandrutu PTAL. |
bogdandrutu
approved these changes
Jun 25, 2019
| ) | ||
|
|
||
| type ( | ||
| event struct { |
There was a problem hiding this comment.
Add that var trick that enforces this struct to implement the Event interface?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.