Fix typos in resource.go. #2201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronilichtman
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
dashpole
approved these changes
Aug 24, 2021
Codecov Report
@@ Coverage Diff @@
## main #2201 +/- ##
=======================================
- Coverage 72.9% 72.8% -0.1%
=======================================
Files 176 176
Lines 12161 12161
=======================================
- Hits 8867 8865 -2
- Misses 3055 3057 +2
Partials 239 239
|
Aneurysm9
approved these changes
Aug 24, 2021
| @@ -43,6 +43,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
| - The `"go.opentelemetry.io/otel/attribute".Any` function now supports `int32` values. (#2169) | |||
| - Multiple calls to `"go.opentelemetry.io/otel/sdk/metric/controller/basic".WithResource()` are handled correctly, and when no resources are provided `"go.opentelemetry.io/otel/sdk/resource".Default()` is used. (#2120) | |||
| - The `WithoutTimestamps` option for the `go.opentelemetry.io/otel/exporters/stdout/stdouttrace` exporter causes the exporter to correctly ommit timestamps. (#2195) | |||
| - Fixed typos in resources.go. (#2201) | |||
There was a problem hiding this comment.
No need to have a changelog entry for this as it just fixes typos in docs and doesn't change anything for users.
MrAlias
approved these changes
Aug 24, 2021
XSAM
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.