Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the import comments of otlpconfig #2224

Merged
merged 3 commits into from
Sep 7, 2021
Merged

Fix the import comments of otlpconfig #2224

merged 3 commits into from
Sep 7, 2021

Conversation

ninjadq
Copy link
Contributor

@ninjadq ninjadq commented Sep 7, 2021

keep import comments of otelpconfig consistent with other

Signed-off-by: DQ dengq@vmware.com

@ninjadq
Fix the import comments of otelpconfig
f7e6986 
keep import comments of otelpconfig consistent with other

Signed-off-by: DQ <dengq@vmware.com>
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 7, 2021 •
edited

CLA Signed

The committers are authorized under a signed CLA.

@XSAM XSAM added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 7, 2021
@pellared pellared changed the title Fix the import comments of otelpconfig Fix the import comments of otlpconfig Sep 7, 2021
@MrAlias MrAlias merged commit df2bdbb into open-telemetry:main Sep 7, 2021
ninjadq added a commit to ninjadq/opentelemetry-go that referenced this pull request Sep 12, 2021
@ninjadq @Aneurysm9 @MrAlias
Fix the import comments of otelpconfig (open-telemetry#2224)
a1b6293 
keep import comments of otelpconfig consistent with other

Signed-off-by: DQ <dengq@vmware.com>

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@thaJeztah thaJeztah mentioned this pull request Sep 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@pellared pellared pellared approved these changes

@MrAlias MrAlias MrAlias approved these changes

@XSAM XSAM XSAM approved these changes

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@evantorrie evantorrie Awaiting requested review from evantorrie evantorrie is a code owner

@jmacd jmacd Awaiting requested review from jmacd

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod MadVikingGod is a code owner

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ninjadq @Aneurysm9 @pellared @MrAlias @XSAM