Add BytesMapCarrier #2245
Add BytesMapCarrier #2245
Conversation
rakyll
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2245 +/- ##
=====================================
Coverage 73.6% 73.6%
=====================================
Files 175 175
Lines 12409 12419 +10
=====================================
+ Hits 9134 9147 +13
+ Misses 3041 3039 -2
+ Partials 234 233 -1
|
Aneurysm9
added
area:propagators
BytesMapCarrier makes it easy for users to inject/extract propagated values from various sources. For example, if a trace context is propagated by an environment variable, users can create a new BytesMapCarrier with values from the environment and inject the trace context into a Go context.
|
Would it not be better if this propagator lives in OTel Go Contrib as it is not required not defined by the spec? |
I don't think the |
| } | ||
|
|
||
| // Set stores the key-value pair. | ||
| func (c BytesMapCarrier) Set(key string, value string) { |
There was a problem hiding this comment.
Why input the value as a string and store it as a []byte?
There was a problem hiding this comment.
Why not store the value as a string, vs. storing as a []byte?
Not blocking, just curiousity. It seems to mean that every call to Get() copies the []byte into a new string because the compiler can't tell that the []byte is never modified.
There was a problem hiding this comment.
@rakyll would you mind following up, here?
| } | ||
|
|
||
| // Set stores the key-value pair. | ||
| func (c BytesMapCarrier) Set(key string, value string) { |
| // BytesMapCarrier is a Carrier that stores propagated | ||
| // values in a map of bytes. |
There was a problem hiding this comment.
| // BytesMapCarrier is a Carrier that stores propagated | |
| // values in a map of bytes. | |
| // BytesMapCarrier adapts map of bytes to satisfy the TextMapCarrier interface. |
|
Is it ok for someone to take over this PR? I opened it but have no bandwidth to follow up right now. |
|
@rakyll We had asked you a question: #2245 (comment) |
The sort.Strings function sorts in increasing order.
Evaluate the sorted keys.
I'm happy to take this over, but I think to @jmacd's point we should probably replace this PR with a one adding a |
|
I've created #2334 as a replacement, please take a look. |
BytesMapCarrier makes it easy for users to inject/extract propagated values from various sources. For example, if a trace context is propagated by an environment variable, users can create a new BytesMapCarrier with values from the environment and inject the trace context into a Go context.
Fixes #2243.