Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix imports in all files except generated files in jaeger exporter #2383

Merged
merged 1 commit into from
Nov 13, 2021

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #2383 (4002798) into main (5e2d218) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2383     +/-   ##
=======================================
- Coverage   73.8%   73.8%   -0.1%     
=======================================
  Files        175     175             
  Lines      12436   12436             
=======================================
- Hits        9185    9183      -2     
- Misses      3015    3017      +2     
  Partials     236     236             
Impacted Files Coverage Δ
bridge/opentracing/internal/mock.go 67.0% <ø> (ø)
bridge/opentracing/wrapper.go 100.0% <ø> (ø)
exporters/jaeger/agent.go 71.1% <ø> (ø)
exporters/jaeger/uploader.go 49.2% <ø> (ø)
.../otlp/otlpmetric/internal/connection/connection.go 3.4% <ø> (ø)
...p/otlpmetric/internal/metrictransform/attribute.go 100.0% <ø> (ø)
...otlp/otlpmetric/internal/metrictransform/metric.go 79.0% <ø> (ø)
...lp/otlpmetric/internal/metrictransform/resource.go 100.0% <ø> (ø)
...tlp/otlpmetric/internal/otlpmetrictest/otlptest.go 0.0% <ø> (ø)
exporters/otlp/otlpmetric/otlpmetricgrpc/client.go 93.7% <ø> (ø)
... and 17 more

Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@MrAlias MrAlias merged commit 4d9d882 into open-telemetry:main Nov 13, 2021
@bogdandrutu bogdandrutu deleted the fiximport branch November 15, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants