Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize the retry package for the otlp exporters #2427

Merged
merged 5 commits into from
Dec 6, 2021

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Dec 3, 2021

Part of #2015

With #2425 merged, the otlptrace and otlpmetric retry packages and use of that package are the same. This remove the duplicate code. It creates a unified exporters/otlp/internal/retry module that both modules can depend on. It is created as a module and not a package of the go.opentelemetry.io/otel module in order to isolate the dependency on the backoff package it uses.

@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #2427 (58cf4de) into main (f4b63f1) will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2427     +/-   ##
=======================================
- Coverage   75.6%   75.4%   -0.2%     
=======================================
  Files        175     174      -1     
  Lines      12170   12113     -57     
=======================================
- Hits        9201    9141     -60     
- Misses      2720    2723      +3     
  Partials     249     249             
Impacted Files Coverage Δ
exporters/otlp/internal/retry/retry.go 98.2% <ø> (ø)
...ers/otlp/otlpmetric/internal/otlpconfig/options.go 52.9% <ø> (ø)
exporters/otlp/otlpmetric/otlpmetricgrpc/client.go 97.7% <ø> (ø)
...xporters/otlp/otlpmetric/otlpmetricgrpc/options.go 78.2% <ø> (ø)
exporters/otlp/otlpmetric/otlpmetrichttp/client.go 78.7% <ø> (ø)
...xporters/otlp/otlpmetric/otlpmetrichttp/options.go 69.2% <ø> (ø)
...ters/otlp/otlptrace/internal/otlpconfig/options.go 52.9% <ø> (ø)
exporters/otlp/otlptrace/otlptracegrpc/client.go 97.7% <ø> (ø)
exporters/otlp/otlptrace/otlptracegrpc/options.go 78.2% <ø> (ø)
exporters/otlp/otlptrace/otlptracehttp/client.go 83.3% <ø> (ø)
... and 2 more

@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 3, 2021
@MrAlias MrAlias merged commit 31661dd into open-telemetry:main Dec 6, 2021
@MrAlias MrAlias deleted the unify-otlp-retry branch December 6, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants