Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sporadic test failure in otlp exporter http client tests #2496

Merged
merged 3 commits into from
Jan 6, 2022

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jan 4, 2022

Apply fix from #1906

Remove the situation where the server hold the processor long enough to timeout before the client by instead using a chan to delay the server that is only closed after the client has timed out.

Fix #2495

@MrAlias MrAlias added bug Something isn't working Skip Changelog PRs that do not require a CHANGELOG.md entry labels Jan 4, 2022
@MrAlias MrAlias marked this pull request as ready for review January 4, 2022 18:31
@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #2496 (15ccfe8) into main (1c1e846) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2496   +/-   ##
=====================================
  Coverage   76.3%   76.3%           
=====================================
  Files        173     173           
  Lines      12022   12022           
=====================================
+ Hits        9175    9179    +4     
+ Misses      2602    2598    -4     
  Partials     245     245           
Impacted Files Coverage Δ
sdk/trace/batch_span_processor.go 85.4% <0.0%> (+2.0%) ⬆️

@hanyuancheung
Copy link
Member

Very fast response for the bugfix. Thank you @MrAlias !

@MrAlias MrAlias merged commit 11ce2dd into open-telemetry:main Jan 6, 2022
@MrAlias MrAlias deleted the fix-2495 branch January 6, 2022 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestTimeout test in the go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp fails sporadically
4 participants