Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not store TracerProvider or Tracer fields in SDK recordingSpan #2575

Merged
merged 4 commits into from
Feb 1, 2022
Merged

Do not store TracerProvider or Tracer fields in SDK recordingSpan #2575

merged 4 commits into from
Feb 1, 2022

Commits on Jan 31, 2022

  1. Do not store TracerProvider fields in span 

    Instead of keeping a reference to the span's Tracer, and therefore also
it's TracerProvider, and the associated resource and spanLimits just
keep the reference to the Tracer. Refer to the TracerProvider fields
when needed instead.
    @MrAlias
    MrAlias committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    55eba49 View commit details
    Browse the repository at this point in the history

  2. Make span refer to the inst lib via the Tracer 

    Instead of holding a field in the span, refer to the field in the parent
Tracer.
    @MrAlias
    MrAlias committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    47efb9d View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2022

  1. Merge branch 'main' into ref-spans-tp

    @MrAlias
    MrAlias committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    c1a264f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into ref-spans-tp

    @MrAlias
    MrAlias committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    947b4ce View commit details
    Browse the repository at this point in the history