[API EPIC 3/4] SDK Wrapper #2586
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadVikingGod
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
The Moved compoents are: - metric/metrictest - metric/number - metric/internal/registry - metric/sdkapi
MadVikingGod
force-pushed
the
metrics-api/3-wrapper
branch
from
cb9677b
to
45e799a
Compare
4 tasks
Aneurysm9
approved these changes
Feb 9, 2022
dashpole
approved these changes
Feb 17, 2022
|
I was going to pull these changes into one on the end if you are ok with that @dashpole. |
MrAlias
approved these changes
Feb 25, 2022
| return a, nil | ||
| } | ||
|
|
||
| func (m *Accumulator) RegisterCallback(insts []instrument.Asynchronous, f func(context.Context)) error { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a series of patches to update the metrics API. Here is the diff against the previous step
This creates a wrapper to enable the use of the current SDK as an implementation of the new API. It does some work to remove now unneeded concepts because we access the API differently.