Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move metric no-op implementation to metric package #2866

merged 5 commits into from Apr 28, 2022


Copy link

This is to be consistent with trace package.

Fixes: #2767

Signed-off-by: Bogdan Drutu

This is to be consistent with trace package.

Fixes: open-telemetry#2767

Signed-off-by: Bogdan Drutu <>
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #2866 (457aec7) into main (a14ecc7) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2866   +/-   ##
  Coverage   75.7%   75.7%           
  Files        178     177    -1     
  Lines      11819   11819           
  Hits        8950    8950           
  Misses      2636    2636           
  Partials     233     233           
Impacted Files Coverage Δ
metric/noop.go 100.0% <100.0%> (ø) Outdated Show resolved Hide resolved
Copy link

@hanyuancheung hanyuancheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


metric/noop.go Outdated Show resolved Hide resolved
Bogdan Drutu and others added 4 commits April 28, 2022 12:29
Co-authored-by: Tyler Yahn <>
Co-authored-by: Chester Cheung <>
@MrAlias MrAlias merged commit a9a5192 into open-telemetry:main Apr 28, 2022
@bogdandrutu bogdandrutu deleted the mvnoop branch May 3, 2022 17:28
@MrAlias MrAlias added this to the Release v1.8.0 milestone Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Inconsistent design for No-Op package choice
3 participants