exporter(stackdriver): fix ExportSpans when ctx is not nil #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
clsung
commented
Nov 6, 2019
clsung
commented
- problem: if ctx is not, calling cancel() will panic
- nil Context already handled in newContextWithTimeout
- add with test
clsung
requested review from
bogdandrutu,
jmacd,
pjanotti,
rghetia,
sjkaris and
tedsuo
as code owners
jmacd
reviewed
Nov 6, 2019
exporter/trace/stackdriver/trace.go
Outdated
| if ctx == nil { | ||
| ctx, cancel = newContextWithTimeout(e.o.Context, e.o.Timeout) | ||
| } | ||
| ctx, cancel = newContextWithTimeout(ctx, e.o.Timeout) |
There was a problem hiding this comment.
There are ctx == nil checks all over this code, could you clarify the intention? Testing for a nil context anywhere has a funny smell. I would like to see all the nil context checks removed.
Also, should you add a test for the case where context reaches the timeout and is canceled?
There was a problem hiding this comment.
I think as long as ctx is not nil, the cancel() will always be nil. However for batch processing we need a timeout function hence we need a ctx with timeout. I'll check it with timeout tests.
rghetia
reviewed
Nov 6, 2019
clsung
force-pushed
the
test_exporter_stackdriver
branch
from
3f2611e
to
475ceab
Compare
|
Paging @ymotongpoo for review (p.s. we should add him to CODEOWNERS for this directory) |
lizthegrey
approved these changes
Nov 8, 2019
rghetia
approved these changes
Nov 11, 2019
- problem: if ctx is not, calling cancel() will panic - nil Context already handled in newContextWithTimeout - add with test
- rename blackbox tests package to stackdriver_test - remove context is nil checking, add to initialization - add tests for timeout
clsung
force-pushed
the
test_exporter_stackdriver
branch
from
475ceab
to
afe0588
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.