Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golangci lint fix #2985

Closed
wants to merge 2 commits into from
Closed

golangci lint fix #2985

wants to merge 2 commits into from

Conversation

Petrie
Copy link
Contributor

@Petrie Petrie commented Jun 29, 2022

No description provided.

@Petrie Petrie marked this pull request as ready for review June 29, 2022 01:20
@codecov
Copy link

codecov bot commented Jun 29, 2022 •
edited

Codecov Report

Merging #2985 (71ee3c9) into main (eb55e60) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2985   +/-   ##
=====================================
  Coverage   76.2%   76.2%           
=====================================
  Files        179     179           
  Lines      11939   11939           
=====================================
+ Hits        9103    9105    +2     
+ Misses      2596    2594    -2     
  Partials     240     240
Impacted Files Coverage Δ
sdk/trace/provider.go 85.5% <100.0%> (ø)
sdk/trace/batch_span_processor.go 81.9% <0.0%> (+0.8%) ⬆️

@pellared pellared added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 29, 2022
@dmathieu
Copy link
Member

Is there a golangci config we should change so those issues fail the CI is they happen again?

@Petrie
Copy link
Contributor Author

Petrie commented Jun 29, 2022

Is there a golangci config we should change so those issues fail the CI is they happen again?

I'll try to solve this.

@Petrie
Copy link
Contributor Author

Petrie commented Jun 30, 2022

I open a new pr #2987 to fix this lint error. with fix the CI exec abnormal phenomenon.

@MadVikingGod MadVikingGod mentioned this pull request Aug 23, 2022
Merged
@MrAlias
Copy link
Contributor

MrAlias commented Oct 27, 2022

Is this still needed?

@Petrie Petrie closed this Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pellared pellared pellared approved these changes

@hanyuancheung hanyuancheung hanyuancheung approved these changes

@jmacd jmacd Awaiting requested review from jmacd

@MrAlias MrAlias Awaiting requested review from MrAlias MrAlias is a code owner

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie evantorrie is a code owner

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod MadVikingGod is a code owner

@dmathieu dmathieu Awaiting requested review from dmathieu dmathieu is a code owner

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Petrie @dmathieu @MrAlias @pellared @hanyuancheung