Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prometheus exporter panic on invalid metric #3182

Merged
merged 3 commits into from
Sep 18, 2022

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Sep 16, 2022

Resolves #3180

@MrAlias MrAlias added bug Something isn't working pkg:exporter:prometheus Related to the Prometheus exporter package labels Sep 16, 2022
@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 16, 2022
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #3182 (4458812) into main (30fcf78) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3182   +/-   ##
=====================================
  Coverage   77.3%   77.4%           
=====================================
  Files        158     158           
  Lines      11084   11084           
=====================================
+ Hits        8577    8583    +6     
+ Misses      2310    2306    -4     
+ Partials     197     195    -2     
Impacted Files Coverage Δ
exporters/prometheus/exporter.go 76.9% <100.0%> (+4.6%) ⬆️

@MrAlias MrAlias merged commit 798b423 into open-telemetry:main Sep 18, 2022
@MrAlias MrAlias deleted the fix-3180 branch September 18, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pkg:exporter:prometheus Related to the Prometheus exporter package Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prometheus server panic on invalid instrument name
5 participants