Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix baggage.NewMember to decode the accepted value #3226

Merged
merged 16 commits into from
Oct 18, 2022

Conversation

NewReStarter
Copy link
Contributor

@NewReStarter NewReStarter commented Sep 22, 2022

fix #3144
fix #2523

Function baggage.NewMember(key, value, props...) input value is decoded and stored after validating the input parameters according to the W3C specification of baggage value.

Corresponding test cases are modified so that we can make sure value is properly encoded before creating baggage.Member.

`value` is decoded and stored after validating the input parameters.

Corresponding test cases are modified so that we can make sure `value` is properly encoded before creating Member.
@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #3226 (94bd4dc) into main (1cbd4c2) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3226   +/-   ##
=====================================
  Coverage   77.8%   77.8%           
=====================================
  Files        164     164           
  Lines      11264   11269    +5     
=====================================
+ Hits        8767    8772    +5     
  Misses      2299    2299           
  Partials     198     198           
Impacted Files Coverage Δ
baggage/baggage.go 97.4% <100.0%> (+<0.1%) ⬆️

@NewReStarter
Copy link
Contributor Author

@MrAlias can you please help approve to run the ci check pipeline?

Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the parse of new baggage work properly? Or does it also need to be included here?

baggage/baggage.go Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
baggage/baggage.go Outdated Show resolved Hide resolved
baggage/baggage.go Outdated Show resolved Hide resolved
baggage/baggage.go Outdated Show resolved Hide resolved
baggage/baggage.go Outdated Show resolved Hide resolved
baggage/baggage.go Outdated Show resolved Hide resolved
propagation/baggage_test.go Outdated Show resolved Hide resolved
@NewReStarter
Copy link
Contributor Author

@MrAlias thx for the comments.
changelog is fixed and redundant comments are removed. I also tried to rephrase and simplify the function document of the new NewMember. Any further suggestions?

CHANGELOG.md Outdated Show resolved Hide resolved
@MrAlias MrAlias merged commit 0963f59 into open-telemetry:main Oct 18, 2022
@MrAlias MrAlias mentioned this pull request Oct 19, 2022
vreynolds added a commit to honeycombio/honeycomb-opentelemetry-go that referenced this pull request Oct 26, 2022
open-telemetry/opentelemetry-go#3226 fixed the behavior of baggage.NewMember to be W3C compliant, which now decodes the value
vreynolds added a commit to honeycombio/honeycomb-opentelemetry-go that referenced this pull request Oct 26, 2022
… to 1.11.1 (#84)

* Bump go.opentelemetry.io/otel/exporters/stdout/stdouttrace

Bumps [go.opentelemetry.io/otel/exporters/stdout/stdouttrace](https://github.com/open-telemetry/opentelemetry-go) from 1.9.0 to 1.11.1.
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.9.0...v1.11.1)

---
updated-dependencies:
- dependency-name: go.opentelemetry.io/otel/exporters/stdout/stdouttrace
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix baggage test

open-telemetry/opentelemetry-go#3226 fixed the behavior of baggage.NewMember to be W3C compliant, which now decodes the value

* drop go 1.17

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Vera Reynolds <verareynolds@honeycomb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants