Fix baggage.NewMember to decode the accepted value #3226
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
`value` is decoded and stored after validating the input parameters. Corresponding test cases are modified so that we can make sure `value` is properly encoded before creating Member.
Additional details and impacted files
@@ Coverage Diff @@ ## main #3226 +/- ## ===================================== Coverage 77.8% 77.8% ===================================== Files 164 164 Lines 11264 11269 +5 ===================================== + Hits 8767 8772 +5 Misses 2299 2299 Partials 198 198
vreynolds added a commit to honeycombio/honeycomb-opentelemetry-go that referenced this pull request
Oct 26, 2022
… to 1.11.1 (#84) * Bump go.opentelemetry.io/otel/exporters/stdout/stdouttrace Bumps [go.opentelemetry.io/otel/exporters/stdout/stdouttrace](https://github.com/open-telemetry/opentelemetry-go) from 1.9.0 to 1.11.1. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](firstname.lastname@example.org...v1.11.1) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel/exporters/stdout/stdouttrace dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <email@example.com> * fix baggage test open-telemetry/opentelemetry-go#3226 fixed the behavior of baggage.NewMember to be W3C compliant, which now decodes the value * drop go 1.17 Signed-off-by: dependabot[bot] <firstname.lastname@example.org> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Vera Reynolds <email@example.com>
This was referenced
Feb 7, 2023
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.