Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default view if instrument does not match any pipeline view #3237

merged 10 commits into from Oct 7, 2022


Copy link

@MrAlias MrAlias commented Sep 27, 2022

Fix #3224

@MrAlias MrAlias added bug Something isn't working pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics labels Sep 27, 2022
@MrAlias MrAlias added this to the Metric v0.32.2 milestone Sep 27, 2022
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #3237 (7a95243) into main (697d245) will increase coverage by 0.0%.
The diff coverage is 76.9%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3237   +/-   ##
  Coverage   77.3%   77.3%           
  Files        159     159           
  Lines      11182   11192   +10     
+ Hits        8647    8656    +9     
  Misses      2337    2337           
- Partials     198     199    +1     
Impacted Files Coverage Δ
sdk/metric/config.go 100.0% <ø> (ø)
sdk/metric/pipeline.go 94.8% <76.9%> (-1.2%) ⬇️
exporters/jaeger/jaeger.go 91.1% <0.0%> (+0.8%) ⬆️


This comment was marked as outdated.

@MrAlias MrAlias reopened this Sep 28, 2022
Copy link

@paivagustavo paivagustavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 just passing by

We should be able to remove this as well:

sdk/metric/pipeline.go Show resolved Hide resolved
Copy link
Contributor Author

MrAlias commented Sep 30, 2022

@paivagustavo I reverted b56efb0. It indeed corrected incorrect behavior, but our tests expected this behavior.

The fix for the issue is included in #3251. I will make sure to handle the merge conflict by including the fix in the default view match based on whichever one is merged first.

@Aneurysm9 Aneurysm9 merged commit c5ebbc4 into open-telemetry:main Oct 7, 2022
@MrAlias MrAlias deleted the default-view branch October 11, 2022 15:13
@MrAlias MrAlias mentioned this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
area:metrics Part of OpenTelemetry Metrics bug Something isn't working pkg:SDK Related to an SDK package
None yet

Successfully merging this pull request may close these issues.

Default view should not be required when other views passed
4 participants