New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OTLP metrics exporter Go module name #3249
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The module name is incorrect, leading `go get` to fail.
cwaldren-ld
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
September 30, 2022 16:44
|
Aneurysm9
approved these changes
Sep 30, 2022
Aneurysm9
added
the
blocked:CLA
Waiting on CLA to be signed before progress can be made
label
Sep 30, 2022
dashpole
approved these changes
Sep 30, 2022
I'm blocked on getting the CLA signoff for my company. If anyone wants to just duplicate this and close this PR, that'd be fine, otherwise it might take a couple days. |
MadVikingGod
approved these changes
Oct 3, 2022
hanyuancheung
approved these changes
Oct 4, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3249 +/- ##
=======================================
- Coverage 77.3% 77.3% -0.1%
=======================================
Files 159 159
Lines 11182 11182
=======================================
- Hits 8651 8649 -2
- Misses 2333 2335 +2
Partials 198 198
|
Closing in favor of #3259 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blocked:CLA
Waiting on CLA to be signed before progress can be made
Skip Changelog
PRs that do not require a CHANGELOG.md entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module name is incorrect, leading
go get
to fail.