Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage, and don't send empty batches in OC bridge #3263

merged 3 commits into from Oct 11, 2022


Copy link

@dashpole dashpole commented Oct 6, 2022

This is a subset of the changes from #3207. It adds tests, and doesn't send empty batches (which was the behavior in the previous opencensus bridge).

Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #3263 (38395a0) into main (4ec2ae6) will increase coverage by 0.1%.
The diff coverage is 60.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3263     +/-   ##
+ Coverage   77.4%   77.5%   +0.1%     
  Files        160     160             
  Lines      11200   11203      +3     
+ Hits        8673    8688     +15     
+ Misses      2328    2315     -13     
- Partials     199     200      +1     
Impacted Files Coverage Δ
bridge/opencensus/metric.go 85.0% <60.0%> (+85.0%) ⬆️
exporters/jaeger/jaeger.go 90.3% <0.0%> (-0.9%) ⬇️

bridge/opencensus/metric_test.go Outdated Show resolved Hide resolved
bridge/opencensus/metric_test.go Outdated Show resolved Hide resolved
@MrAlias MrAlias merged commit ffa94ca into open-telemetry:main Oct 11, 2022
@MrAlias MrAlias mentioned this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants