Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix with the correct import packages in main.go #3354

merged 3 commits into from Oct 19, 2022


Copy link

@fangn2 fangn2 commented Oct 18, 2022

This PR fixs the import packages section of main.go in which is not synced with the source code.

Following current getting-started guide as it misses few packages in the import, it will result in error.
Check error message as blow:
dev-dsk-nhfang % go run .
# fib
./main.go:27:21: undefined: resource
./main.go:28:10: undefined: resource
./main.go:29:3: undefined: resource
./main.go:30:3: undefined: resource
./main.go:34:4: undefined: attribute
./main.go:67:2: undefined: signal

Copy link

linux-foundation-easycla bot commented Oct 18, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: fangn2 / name: Tony_F (16d6c19) Outdated Show resolved Hide resolved
@pellared pellared added the Skip Changelog PRs that do not require a entry label Oct 18, 2022
Copy link

pellared commented Oct 18, 2022

@fangn2 Thanks for the PR ❤️

Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #3354 (352dcd7) into main (ad45631) will decrease coverage by 0.0%.
The diff coverage is n/a.

❗ Current head 352dcd7 differs from pull request most recent head 69f291b. Consider uploading reports for the commit 69f291b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3354     +/-   ##
- Coverage   77.8%   77.8%   -0.1%     
  Files        164     164             
  Lines      11278   11264     -14     
- Hits        8778    8765     -13     
+ Misses      2303    2301      -2     
- Partials     197     198      +1     
Impacted Files Coverage Δ
exporters/prometheus/exporter.go 80.0% <0.0%> (-1.5%) ⬇️
baggage/baggage.go 97.3% <0.0%> (-0.1%) ⬇️
exporters/prometheus/config.go 100.0% <0.0%> (ø)
exporters/jaeger/jaeger.go 91.1% <0.0%> (+0.8%) ⬆️
sdk/trace/batch_span_processor.go 81.1% <0.0%> (+0.8%) ⬆️

@MrAlias MrAlias added the documentation Provides helpful information label Oct 18, 2022
@MrAlias MrAlias merged commit 6c0a7c4 into open-telemetry:main Oct 19, 2022
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
documentation Provides helpful information Skip Changelog PRs that do not require a entry
None yet

Successfully merging this pull request may close these issues.

None yet

6 participants