Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds attribute filter logic #3396

Merged
merged 7 commits into from Nov 8, 2022

Conversation

MadVikingGod
Copy link
Contributor

This re-adds the ability for a view to filter by attribute key.

This does expose a bug in the sum async aggregation with filtering.

@MadVikingGod MadVikingGod linked an issue Oct 25, 2022 that may be closed by this pull request
1 task
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #3396 (513b3db) into main (bdc26f3) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3396     +/-   ##
=======================================
- Coverage   77.8%   77.8%   -0.1%     
=======================================
  Files        164     164             
  Lines      11494   11497      +3     
=======================================
+ Hits        8944    8945      +1     
- Misses      2347    2349      +2     
  Partials     203     203             
Impacted Files Coverage Δ
sdk/metric/pipeline.go 93.5% <100.0%> (+<0.1%) ⬆️
sdk/trace/batch_span_processor.go 80.2% <0.0%> (-0.9%) ⬇️

@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics labels Oct 25, 2022
sdk/metric/meter_test.go Show resolved Hide resolved
sdk/metric/meter_test.go Outdated Show resolved Hide resolved
sdk/metric/meter_test.go Outdated Show resolved Hide resolved
sdk/metric/meter_test.go Outdated Show resolved Hide resolved
sdk/metric/meter_test.go Outdated Show resolved Hide resolved
sdk/metric/meter_test.go Outdated Show resolved Hide resolved
sdk/metric/meter_test.go Outdated Show resolved Hide resolved
sdk/metric/meter_test.go Outdated Show resolved Hide resolved
sdk/metric/meter_test.go Outdated Show resolved Hide resolved
sdk/metric/meter_test.go Outdated Show resolved Hide resolved
@MrAlias MrAlias mentioned this pull request Oct 27, 2022
1 task
@MrAlias MrAlias added this to the Metric v0.34.0 milestone Oct 27, 2022
@MrAlias MrAlias merged commit c21b6b6 into open-telemetry:main Nov 8, 2022
20 checks passed
@MadVikingGod MadVikingGod deleted the mvg/readd-filter branch February 21, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Use view AttributeFilter
3 participants