Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multi-instrument callbacks to be unregistered #3522

Merged
merged 18 commits into from
Dec 16, 2022
Merged

Allow multi-instrument callbacks to be unregistered #3522

merged 18 commits into from
Dec 16, 2022

Commits on Dec 6, 2022

  1. Update Meter RegisterCallback method 

    Return a Registration from the method that can be used by the caller to
unregister their callback.

Update documentation of the method to better explain expectations of
use and implementation.
    @MrAlias
    MrAlias committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    1ec1112 View commit details
    Browse the repository at this point in the history

  2. Update noop impl

    @MrAlias
    MrAlias committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    a17f123 View commit details
    Browse the repository at this point in the history

  3. Update global impl

    @MrAlias
    MrAlias committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    41a433e View commit details
    Browse the repository at this point in the history

  4. Test global Unregister concurrent safe

    @MrAlias
    MrAlias committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    6e47a27 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. Use a map to track reg in global impl

    @MrAlias
    MrAlias committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    1b74247 View commit details
    Browse the repository at this point in the history

  2. Update sdk impl

    @MrAlias
    MrAlias committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    ad30134 View commit details
    Browse the repository at this point in the history

  3. Use a list for global impl

    @MrAlias
    MrAlias committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    cfa2348 View commit details
    Browse the repository at this point in the history

  4. Fix prom example

    @MrAlias
    MrAlias committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    be40648 View commit details
    Browse the repository at this point in the history

  5. Lint metric/meter.go

    @MrAlias
    MrAlias committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    35ba6ad View commit details
    Browse the repository at this point in the history

  6. Fix metric example

    @MrAlias
    MrAlias committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    958b5a2 View commit details
    Browse the repository at this point in the history

  7. Placeholder for changelog

    @MrAlias
    MrAlias committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    84266b2 View commit details
    Browse the repository at this point in the history

  8. Update PR number in changelog

    @MrAlias
    MrAlias committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    ea064bb View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into unreg-async

    @MrAlias
    MrAlias committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    4ebc38c View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2022

  1. Merge branch 'main' into unreg-async

    @MrAlias
    MrAlias committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    b2c4778 View commit details
    Browse the repository at this point in the history

  2. Update sdk/metric/pipeline.go 

    Co-authored-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
    @MrAlias @MadVikingGod
    MrAlias and MadVikingGod committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    db62d9e View commit details
    Browse the repository at this point in the history

  3. Add test unregistered callback is not called

    @MrAlias
    MrAlias committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    c56c140 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. Merge branch 'main' into unreg-async

    @MrAlias
    MrAlias committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    288e465 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. Merge branch 'main' into unreg-async

    @MrAlias
    MrAlias committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    5069a4f View commit details
    Browse the repository at this point in the history