Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create metric API Callback type #3564

Merged
merged 5 commits into from Jan 5, 2023
Merged

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jan 5, 2023

Document the type according the OTel specification requirements.

Resolve #3563

@MrAlias MrAlias added pkg:API Related to an API package area:metrics Part of OpenTelemetry Metrics labels Jan 5, 2023
@MrAlias MrAlias added this to the Metric v0.35.0 milestone Jan 5, 2023
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #3564 (94ede32) into main (efd8a7d) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3564   +/-   ##
=====================================
  Coverage   77.9%   77.9%           
=====================================
  Files        163     163           
  Lines      11850   11850           
=====================================
+ Hits        9235    9239    +4     
+ Misses      2417    2413    -4     
  Partials     198     198           
Impacted Files Coverage Δ
metric/internal/global/meter.go 95.2% <100.0%> (ø)
metric/noop.go 62.1% <100.0%> (ø)
sdk/metric/meter.go 92.1% <100.0%> (ø)
sdk/metric/pipeline.go 93.9% <100.0%> (ø)
exporters/jaeger/jaeger.go 91.1% <0.0%> (+0.8%) ⬆️
sdk/trace/batch_span_processor.go 81.9% <0.0%> (+0.8%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:API Related to an API package
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

Document the callback registered with a Meter according to the specification
3 participants