Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove leftover instrument provider from noop #3736

Merged
merged 4 commits into from
Feb 16, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Feb 15, 2023

Cleanup missed by #3530

@MrAlias MrAlias added pkg:API Related to an API package area:metrics Part of OpenTelemetry Metrics Skip Changelog PRs that do not require a CHANGELOG.md entry labels Feb 15, 2023
@MrAlias MrAlias added this to the Metric v0.37.0 milestone Feb 15, 2023
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #3736 (a272375) into main (0252734) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3736     +/-   ##
=======================================
+ Coverage   81.3%   81.5%   +0.1%     
=======================================
  Files        166     166             
  Lines      12451   12425     -26     
=======================================
  Hits       10130   10130             
+ Misses      2105    2079     -26     
  Partials     216     216             
Impacted Files Coverage Δ
metric/noop.go 97.2% <100.0%> (+36.9%) ⬆️
sdk/trace/batch_span_processor.go 81.9% <0.0%> (+0.8%) ⬆️

@MrAlias MrAlias merged commit 59daa05 into open-telemetry:main Feb 16, 2023
@MrAlias MrAlias deleted the rm-leftover-noop branch February 16, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:API Related to an API package Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants