-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap errors returned from Detect
and New
in sdk/resource
#3844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3844 +/- ##
=====================================
Coverage 81.7% 81.7%
=====================================
Files 168 168
Lines 12462 12477 +15
=====================================
+ Hits 10182 10195 +13
- Misses 2065 2067 +2
Partials 215 215
|
Test that New returns an error that can be unwrapped.
Aneurysm9
approved these changes
Mar 7, 2023
mwear
approved these changes
Mar 8, 2023
dmathieu
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the errors returned from these functions do not wrap errors. This means that external users cannot use the Go
errors.Is
function to test their error is successfully returned from their resource detectors1. This resolves this introducing an unwrap-abledetectErr
that is returned from an new internal copy ofDetect
.The internal copy of
Detect
,detect
, is used to allowNew
to pass a resource with the appropriate schema URL set. This means the schema URL collision ofdetect
is reused instead of duplicating the functionality forNew
. Also, this avoid an additional allocation when the returned*Resource
fromDetect
inNew
was discarded when it was later merged into another new*Resource
.Footnotes
https://github.com/open-telemetry/opentelemetry-go/pull/3812#discussion_r1120995919 ↩