Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the metric Export interface to accept a *ResourceMetrics instead of ResourceMetrics #3853

Merged
merged 11 commits into from
Mar 16, 2023

Conversation

unicod3
Copy link
Contributor

@unicod3 unicod3 commented Mar 9, 2023

Resolves #3852

Hello, I am not sure if that requires a change log, I can update it if it does.

Updated the change log

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #3853 (6542d83) into main (3a40e65) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3853     +/-   ##
=======================================
- Coverage   81.6%   81.5%   -0.1%     
=======================================
  Files        169     169             
  Lines      12723   12711     -12     
=======================================
- Hits       10383   10371     -12     
  Misses      2121    2121             
  Partials     219     219             
Impacted Files Coverage Δ
bridge/opencensus/metric.go 92.5% <100.0%> (ø)
exporters/otlp/otlpmetric/internal/exporter.go 67.2% <100.0%> (ø)
...s/otlp/otlpmetric/internal/transform/metricdata.go 100.0% <100.0%> (ø)
exporters/stdout/stdoutmetric/exporter.go 91.8% <100.0%> (-0.9%) ⬇️
sdk/metric/periodic_reader.go 91.8% <100.0%> (ø)

... and 2 files with indirect coverage changes

@MrAlias
Copy link
Contributor

MrAlias commented Mar 10, 2023

Resolves #3852

Hello, I am not sure if that requires a change log, I can update it if it does.

Thanks for the contribution! Please do add a changelog entry for the exported Exporter interface change so exporter authors know to update things.

CHANGELOG.md Outdated Show resolved Hide resolved
exporters/otlp/otlpmetric/internal/exporter_test.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
exporters/stdout/stdoutmetric/exporter_test.go Outdated Show resolved Hide resolved
exporters/stdout/stdoutmetric/exporter_test.go Outdated Show resolved Hide resolved
@unicod3 unicod3 requested a review from pellared March 13, 2023 20:25
@unicod3 unicod3 requested a review from dubonzi March 16, 2023 15:10
CHANGELOG.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Update the metric Export interface to accept a *ResourceMetrics instead of ResourceMetrics
4 participants