Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Synchronous and rename Asynchronous #3892

Merged
merged 6 commits into from
Mar 20, 2023
Merged

Remove Synchronous and rename Asynchronous #3892

merged 6 commits into from
Mar 20, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Mar 15, 2023 •
edited
Loading

Resolves #3871

@MrAlias MrAlias added pkg:API Related to an API package actions Pull requests that update GitHub action code labels Mar 15, 2023
@MrAlias MrAlias added this to the v1.15.0 milestone Mar 15, 2023
@codecov
Copy link

codecov bot commented Mar 15, 2023 •
edited
Loading

Codecov Report

Merging #3892 (0fa8827) into main (4ccd590) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3892     +/-   ##
=======================================
- Coverage   81.6%   81.6%   -0.1%     
=======================================
  Files        169     169             
  Lines      12711   12711             
=======================================
- Hits       10375   10373      -2     
- Misses      2117    2119      +2     
  Partials     219     219
Impacted Files Coverage Δ
metric/instrument/asyncfloat64.go 100.0% <ø> (ø)
metric/instrument/asyncint64.go 100.0% <ø> (ø)
metric/instrument/instrument.go 100.0% <ø> (ø)
metric/instrument/syncfloat64.go 100.0% <ø> (ø)
metric/instrument/syncint64.go 100.0% <ø> (ø)
sdk/metric/instrument.go 96.0% <ø> (ø)
internal/global/instruments.go 60.8% <100.0%> (ø)
internal/global/meter.go 93.8% <100.0%> (ø)
metric/noop.go 97.2% <100.0%> (ø)
sdk/metric/meter.go 89.5% <100.0%> (ø)
... and 1 more

... and 1 file with indirect coverage changes

@MrAlias MrAlias added area:metrics Part of OpenTelemetry Metrics and removed actions Pull requests that update GitHub action code labels Mar 15, 2023
@MrAlias MrAlias marked this pull request as ready for review March 15, 2023 21:37
@MrAlias MrAlias merged commit b7b53bb into open-telemetry:main Mar 20, 2023
@MrAlias MrAlias deleted the metric-api-sync-async-ifaces branch March 20, 2023 20:26
@MrAlias MrAlias modified the milestones: v1.15.0, v1.15.0-RC2 Mar 22, 2023
@MrAlias MrAlias mentioned this pull request Mar 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@pellared pellared pellared approved these changes

@jmacd jmacd Awaiting requested review from jmacd

@evantorrie evantorrie Awaiting requested review from evantorrie

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod MadVikingGod is a code owner

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung hanyuancheung is a code owner

@dmathieu dmathieu Awaiting requested review from dmathieu dmathieu is a code owner

Assignees
No one assigned
Labels
area:metrics Part of OpenTelemetry Metrics pkg:API Related to an API package
Projects
No open projects
Go: Metric API (GA)
Status: Done
Milestone
v1.15.0-RC2
Development

Successfully merging this pull request may close these issues.

The Synchronous and Asynchronous interfaces are not needed in the metric API
3 participants
@MrAlias @Aneurysm9 @pellared