Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split metric configuration down to instrument #3895

Merged
merged 9 commits into from
Mar 21, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Mar 16, 2023

Resolves #3889
Resolves #3872

In order to ensure forward compatibility with fine-grain configuration of each instrument, split the instrument configuration to be per instrument.

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #3895 (83c5666) into main (6eb1157) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3895     +/-   ##
=======================================
+ Coverage   81.6%   81.8%   +0.1%     
=======================================
  Files        169     169             
  Lines      12711   12855    +144     
=======================================
+ Hits       10375   10517    +142     
- Misses      2117    2119      +2     
  Partials     219     219             
Impacted Files Coverage Δ
internal/global/instruments.go 60.8% <ø> (ø)
internal/global/meter.go 93.8% <100.0%> (ø)
metric/instrument/asyncfloat64.go 100.0% <100.0%> (ø)
metric/instrument/asyncint64.go 100.0% <100.0%> (ø)
metric/instrument/instrument.go 100.0% <100.0%> (ø)
metric/instrument/syncfloat64.go 100.0% <100.0%> (ø)
metric/instrument/syncint64.go 100.0% <100.0%> (ø)
metric/noop.go 97.2% <100.0%> (ø)
sdk/metric/meter.go 89.5% <100.0%> (ø)

... and 1 file with indirect coverage changes

@MrAlias MrAlias marked this pull request as ready for review March 16, 2023 16:18
@MrAlias MrAlias added pkg:API Related to an API package area:metrics Part of OpenTelemetry Metrics labels Mar 16, 2023
@MrAlias MrAlias added this to the v1.15.0 milestone Mar 16, 2023
@MrAlias

This comment was marked as resolved.

metric/instrument/asyncfloat64.go Show resolved Hide resolved
@MadVikingGod MadVikingGod merged commit 90df525 into open-telemetry:main Mar 21, 2023
@MrAlias MrAlias deleted the per-inst-config branch March 21, 2023 14:30
@MrAlias MrAlias modified the milestones: v1.15.0, v1.15.0-RC2 Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:API Related to an API package
Projects
No open projects
Status: Done
4 participants