Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance internal logging #3900

Merged
merged 13 commits into from
Mar 21, 2023

Conversation

unicod3
Copy link
Contributor

@unicod3 unicod3 commented Mar 18, 2023

Resolves #3866

I've used the table below as suggested on the issue:

Name LogR Severity
Error 0
Warn 1
Info 4
Debug 8

@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@3c75a44). Click here to learn what that means.
The diff coverage is 100.0%.

❗ Current head bbd53d9 differs from pull request most recent head 36112e5. Consider uploading reports for the commit 36112e5 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##             main   #3900   +/-   ##
======================================
  Coverage        ?   81.8%           
======================================
  Files           ?     169           
  Lines           ?   12857           
  Branches        ?       0           
======================================
  Hits            ?   10521           
  Misses          ?    2117           
  Partials        ?     219           
Impacted Files Coverage Δ
internal/global/internal_logging.go 100.0% <100.0%> (ø)

CHANGELOG.md Outdated Show resolved Hide resolved
pellared
pellared previously approved these changes Mar 20, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Robert Pająk <pellared@hotmail.com>
CHANGELOG.md Outdated Show resolved Hide resolved
@MadVikingGod
Copy link
Contributor

I don't object to this, it's as good as any other, but where are we going to use the warn vs info?

@MrAlias
Copy link
Contributor

MrAlias commented Mar 20, 2023

I don't object to this, it's as good as any other, but where are we going to use the warn vs info?

#3854

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@pellared pellared dismissed their stale review March 21, 2023 17:40

The changelog needs to be updated

@unicod3 unicod3 requested review from pellared and removed request for MadVikingGod March 21, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Warn internal logging function
4 participants