Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to opencensus bridge, and install tracer instead of returning #4567

Merged
merged 7 commits into from Sep 29, 2023

Conversation

dashpole
Copy link
Contributor

Part of #4562

Changes:

  • Add options to trace and metric bridges
  • Add trace option to specify TracerProvider, which defaults to the global TracerProvider.
  • Add InstallTraceBridge(), which simplifies the user experience by setting the DefaultTracer in OpenCensus.
  • Deprecate NewTracer

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #4567 (a50c982) into main (0022098) will decrease coverage by 0.1%.
The diff coverage is 77.7%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4567     +/-   ##
=======================================
- Coverage   81.3%   81.3%   -0.1%     
=======================================
  Files        220     221      +1     
  Lines      17669   17686     +17     
=======================================
+ Hits       14380   14391     +11     
- Misses      2989    2995      +6     
  Partials     300     300             
Files Coverage Δ
bridge/opencensus/config.go 100.0% <100.0%> (ø)
bridge/opencensus/metric.go 100.0% <100.0%> (ø)
bridge/opencensus/trace.go 0.0% <0.0%> (ø)

... and 1 file with indirect coverage changes

bridge/opencensus/config.go Show resolved Hide resolved
bridge/opencensus/bridge.go Outdated Show resolved Hide resolved
@MrAlias MrAlias merged commit 0f09b9b into open-telemetry:main Sep 29, 2023
23 of 24 checks passed
@MrAlias MrAlias added this to the v1.20.0 milestone Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants