-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log: Implement Value and KeyValue types #4949
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4949 +/- ##
=======================================
+ Coverage 82.6% 82.9% +0.2%
=======================================
Files 238 238
Lines 19038 19182 +144
=======================================
+ Hits 15742 15903 +161
+ Misses 3005 2987 -18
- Partials 291 292 +1
|
e2e6ea3
to
755c523
Compare
755c523
to
61b279b
Compare
61b279b
to
2e82b98
Compare
This was referenced Feb 20, 2024
pellared
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
EDIT: All my comments should be addressed as separate issues/PRs.
hanyuancheung
approved these changes
Feb 21, 2024
This was referenced Feb 21, 2024
Closed
Value
and KeyValue
in types otel/log
in types
otel/log`
in types
otel/log`
dmathieu
approved these changes
Feb 21, 2024
dashpole
reviewed
Feb 21, 2024
dashpole
approved these changes
Feb 21, 2024
This was referenced Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #4914